Issue 29721697: Noissue - fix support of namespace, external user-config.h and debug configuration

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29721697: Noissue - fix support of namespace, external user-config.h and debug configuration (Closed)

Created:
March 13, 2018, 4:28 p.m. by sergei

Modified:
March 14, 2018, 10:20 a.m.

Reviewers:
René Jeschke, hub, Oleksandr

Base URL:
https://github.com/adblockplus/adblockpluscore.git@caf1800ce0342583de4c0320745f0fdb3b55bd01

Visibility:
Public.

Description

This commit consists from barely separable changes which are: - add missing header <locale> which is required on linux for std::wstring_convert - add missing ABP_NS in few places - fix wrong type of the second argument for assert2 - use corresponding compiler arguments for debug buildtype - implement missing Log* functions for tests because otherwise tests cannot be linked - add compilation (with following run of the tests) with external user-config-test-namespace.h which also defines a custom namespace. Review: https://codereview.adblockplus.org/29721697

Patch Set 1 #

Patch Set 2 : get rid of the warning #

Created: March 13, 2018, 6:17 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -15 lines)			Patch
M	.travis/travis-script.sh	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	compiled/Map.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	compiled/String.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	compiled/debug.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	compiled/library.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	compiled/library.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	meson.build	View		2 chunks	+2 lines, -1 line	0 comments	Download
A +	test/compiled/library.cpp	View		1 chunk	+21 lines, -4 lines	0 comments	Download
A +	test/compiled/user-config-test-namespace.h	View		1 chunk	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

sergei

I have spotted the warning, the patchset is updated, CI is not finished though.

March 13, 2018, 6:19 p.m. (2018-03-13 18:19:15 UTC) #3

LGTM

Expand All Messages | Collapse All Messages