compiled/library.cpp - Issue 29721753: Issue 6180 - use ABP_TEXT everywhere in order to let String be a UTF-8 string

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: compiled/library.cpp

Issue 29721753: Issue 6180 - use ABP_TEXT everywhere in order to let String be a UTF-8 string (Closed) Base URL: https://github.com/adblockplus/adblockpluscore.git@adb2678354813ce5b6de095072954c5a784a7bc4

Patch Set: rebase Created March 15, 2018, 1:53 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: compiled/library.cpp

diff --git a/compiled/library.cpp b/compiled/library.cpp

index 68a2fd22edd26ba37e7672273ebf3f1d4b29e147..eaaf9b919d719848d572ea1015e3876f12012e6d 100644

--- a/compiled/library.cpp

+++ b/compiled/library.cpp

@@ -71,7 +71,7 @@ bool TestRegExp(RegExpID id, const String& str)

if ((id < regexPool.size()) && regexPool[id])

return std::regex_match(StdWStringFromString(str), *regexPool[id]);

- assert2(id < regexPool.size() && regexPool[id], u"Invalid RegExp index."_str);

+ assert2(id < regexPool.size() && regexPool[id], ABP_TEXT("Invalid RegExp index."_str));

return false;

}

« no previous file with comments | « compiled/intrusive_ptr.h ('k') | compiled/storage/FilterStorage.cpp » ('j') | no next file with comments »