Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(474)

Issue 29733646: Issue 6396 - Error creating non debug build config (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by anton
Modified:
1 year, 11 months ago
Visibility:
Public.

Description

Issue 6396 - Error creating non debug build config Files are relative to `src/v8` directory. Applied to V8 Version 6.4.102 (from Chromium 64.0.3249.2), same as https://codereview.adblockplus.org/29720588/ but for this version of Chromium. This helps to build apk in Release mode with V8 as shared library (by default for Release is_component_build=false and all the libs are compiled into static libraries). # Requires https://gitlab.com/eyeo/adblockplus/chromium/merge_requests/10

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -14 lines) Patch
M BUILD.gn View 9 chunks +18 lines, -8 lines 0 comments Download
M gni/v8.gni View 2 chunks +30 lines, -5 lines 1 comment Download
M src/inspector/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
anton
2 years ago (2018-03-26 10:51:32 UTC) #1
jens
On 2018/03/26 10:51:32, anton wrote: LGTM
1 year, 11 months ago (2018-04-11 15:54:07 UTC) #2
diegocarloslima
LGTM, with a small remark related to a comment https://codereview.adblockplus.org/29733646/diff/29733647/gni/v8.gni File gni/v8.gni (right): https://codereview.adblockplus.org/29733646/diff/29733647/gni/v8.gni#newcode176 gni/v8.gni:176: ...
1 year, 11 months ago (2018-04-11 15:56:36 UTC) #3
anton
1 year, 11 months ago (2018-04-12 06:05:24 UTC) #4
On 2018/04/11 15:56:36, diegocarloslima wrote:
> LGTM, with a small remark related to a comment
> 
> https://codereview.adblockplus.org/29733646/diff/29733647/gni/v8.gni
> File gni/v8.gni (right):
> 
>
https://codereview.adblockplus.org/29733646/diff/29733647/gni/v8.gni#newcode176
> gni/v8.gni:176: output_extension = "cr.so" # in order to load this app V8
shared
> library, not system one
> I would just suggest to put this comment above the code instead of on its side

Thanks guys
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5