Issue 29733646: Issue 6396 - Error creating non debug build config

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29733646: Issue 6396 - Error creating non debug build config (Closed)

Created:
March 26, 2018, 10:47 a.m. by anton

Modified:
April 12, 2018, 6:05 a.m.

Reviewers:
sergei, diegocarloslima, Oleksandr, jens

Visibility:
Public.

Description

Issue 6396 - Error creating non debug build config Files are relative to `src/v8` directory. Applied to V8 Version 6.4.102 (from Chromium 64.0.3249.2), same as https://codereview.adblockplus.org/29720588/ but for this version of Chromium. This helps to build apk in Release mode with V8 as shared library (by default for Release is_component_build=false and all the libs are compiled into static libraries). # Requires https://gitlab.com/eyeo/adblockplus/chromium/merge_requests/10

Patch Set 1 #

Total comments: 1

Created: March 26, 2018, 10:47 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -14 lines)			Patch
M	BUILD.gn	View	9 chunks	+18 lines, -8 lines	0 comments	Download
M	gni/v8.gni	View	2 chunks	+30 lines, -5 lines	1 comment	Download
M	src/inspector/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

diegocarloslima

LGTM, with a small remark related to a comment https://codereview.adblockplus.org/29733646/diff/29733647/gni/v8.gni File gni/v8.gni (right): https://codereview.adblockplus.org/29733646/diff/29733647/gni/v8.gni#newcode176 gni/v8.gni:176: ...

April 11, 2018, 3:56 p.m. (2018-04-11 15:56:36 UTC) #3

anton

April 12, 2018, 6:05 a.m. (2018-04-12 06:05:24 UTC) #4

On 2018/04/11 15:56:36, diegocarloslima wrote:
> LGTM, with a small remark related to a comment
> 
> https://codereview.adblockplus.org/29733646/diff/29733647/gni/v8.gni
> File gni/v8.gni (right):
> 
>
https://codereview.adblockplus.org/29733646/diff/29733647/gni/v8.gni#newcode176
> gni/v8.gni:176: output_extension = "cr.so" # in order to load this app V8
shared
> library, not system one
> I would just suggest to put this comment above the code instead of on its side

Thanks guys

Expand All Messages | Collapse All Messages