Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(61)

Issue 29747555: Issue 6531 - remove inspector and adapt for Android NDK r16b (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 2 days ago by sergei
Modified:
6 days, 22 hours ago
Reviewers:
hub, Oleksandr
CC:
anton, René Jeschke
Base URL:
https://github.com/abby-sergz/v8-googlesource.git@7fece33157c55b16decdf4cde199ca3dddc17db3
Visibility:
Public.

Patch Set 1 #

Total comments: 10

Patch Set 2 : address commnet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M gypfiles/standalone.gypi View 7 chunks +16 lines, -9 lines 0 comments Download
M src/arm/simulator-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/v8.gyp View 3 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 5
sergei
AFAIR previous time it was landed without review, currently there is again the time pressure, ...
2 weeks, 2 days ago (2018-04-09 09:48:11 UTC) #1
hub
https://codereview.adblockplus.org/29747555/diff/29747556/src/arm/simulator-arm.h File src/arm/simulator-arm.h (right): https://codereview.adblockplus.org/29747555/diff/29747556/src/arm/simulator-arm.h#newcode216 src/arm/simulator-arm.h:216: int32_t CallFPImpl(byte* entry, double d0, double d1); On 2018/04/09 ...
2 weeks ago (2018-04-11 01:55:14 UTC) #2
sergei
https://codereview.adblockplus.org/29747555/diff/29747556/src/arm/simulator-arm.h File src/arm/simulator-arm.h (right): https://codereview.adblockplus.org/29747555/diff/29747556/src/arm/simulator-arm.h#newcode216 src/arm/simulator-arm.h:216: int32_t CallFPImpl(byte* entry, double d0, double d1); On 2018/04/11 ...
2 weeks ago (2018-04-11 09:34:44 UTC) #3
hub
LGTM
2 weeks ago (2018-04-11 09:44:31 UTC) #4
sergei
2 weeks ago (2018-04-11 09:46:53 UTC) #5
I'm going to land it.

https://codereview.adblockplus.org/29747555/diff/29747556/src/v8.gyp
File src/v8.gyp (left):

https://codereview.adblockplus.org/29747555/diff/29747556/src/v8.gyp#oldcode40
src/v8.gyp:40: 'includes': ['../gypfiles/toolchain.gypi',
'../gypfiles/features.gypi', 'inspector/inspector.gypi'],
On 2018/04/09 09:48:10, sergei wrote:
> As in the previous changes
>
(https://github.com/adblockplus/v8-googlesource/commit/9a4991959e231351e52266b...)
> we drop the inspector because it's not used.

Forgot to mention that that inspector is not merely used, it even causes
compilation errors, so it's removed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5