Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29756669: Noissue - Adapt best practices for trailing commas (python-abp) (Closed)

Created:
April 19, 2018, 12:55 p.m. by Sebastian Noack
Modified:
April 19, 2018, 4:21 p.m.
Reviewers:
Vasily Kuznetsov
Visibility:
Public.

Description

Noissue - Adapt best practices for trailing commas (python-abp)

Patch Set 1 #

Patch Set 2 : Re-run script on Python 2, added flake8-commas extension #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M abp/filters/render_script.py View 1 chunk +1 line, -1 line 0 comments Download
M setup.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/test_parser.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tox.ini View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
see https://codereview.adblockplus.org/29756624/
April 19, 2018, 12:56 p.m. (2018-04-19 12:56:21 UTC) #1
Vasily Kuznetsov
LGTM
April 19, 2018, 2:27 p.m. (2018-04-19 14:27:05 UTC) #2
Sebastian Noack
After re-running my script with Python 2, flake8-commas found some more missing commas. Also I ...
April 19, 2018, 2:45 p.m. (2018-04-19 14:45:10 UTC) #3
Vasily Kuznetsov
April 19, 2018, 3:38 p.m. (2018-04-19 15:38:33 UTC) #4
On 2018/04/19 14:45:10, Sebastian Noack wrote:
> After re-running my script with Python 2, flake8-commas found some more
missing
> commas. Also I added the flake8-commas extension to the tox.ini.

LGTM

Powered by Google App Engine
This is Rietveld