Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29756692: Noissue - Adapt best practices for trailing commas (cms) (Closed)

Created:
April 19, 2018, 1:09 p.m. by Sebastian Noack
Modified:
April 19, 2018, 4:21 p.m.
Reviewers:
Vasily Kuznetsov
CC:
Jon Sonesen, rosie
Visibility:
Public.

Description

Noissue - Adapt best practices for trailing commas (cms)

Patch Set 1 #

Patch Set 2 : Manual cleanup #

Total comments: 3

Patch Set 3 : More cleanup, added flake8-commas extension #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -35 lines) Patch
M cms/bin/translate.py View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M cms/converters.py View 9 chunks +13 lines, -13 lines 0 comments Download
M cms/sources.py View 1 2 2 chunks +10 lines, -15 lines 0 comments Download
M cms/utils.py View 1 chunk +1 line, -1 line 0 comments Download
M runserver.spec View 1 chunk +1 line, -1 line 0 comments Download
M tests/test_additional_paths.py View 1 chunk +1 line, -1 line 0 comments Download
M tox.ini View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4
Sebastian Noack
see see https://codereview.adblockplus.org/29756624/
April 19, 2018, 1:10 p.m. (2018-04-19 13:10:24 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29756692/diff/29756702/cms/bin/translate.py File cms/bin/translate.py (right): https://codereview.adblockplus.org/29756692/diff/29756702/cms/bin/translate.py#newcode52 cms/bin/translate.py:52: request_method, str(url), **kwargs Apparently flake8-commas insist on comma after ...
April 19, 2018, 1:51 p.m. (2018-04-19 13:51:19 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29756692/diff/29756702/cms/bin/translate.py File cms/bin/translate.py (right): https://codereview.adblockplus.org/29756692/diff/29756702/cms/bin/translate.py#newcode52 cms/bin/translate.py:52: request_method, str(url), **kwargs On 2018/04/19 13:51:19, Sebastian Noack wrote: ...
April 19, 2018, 2:23 p.m. (2018-04-19 14:23:34 UTC) #3
Vasily Kuznetsov
April 19, 2018, 3:52 p.m. (2018-04-19 15:52:55 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld