Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(658)

Issue 29761555: #8852 - ldap sync output filter (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 3 weeks ago by l.rosilio
Modified:
2 months, 2 weeks ago
Reviewers:
mathias, f.lopez
CC:
Fred, mathias
Visibility:
Public.

Description

#8852 - ldap sync output filter

Patch Set 1 #

Total comments: 5

Patch Set 2 : #8852 - ldap sync output filter #

Total comments: 8

Patch Set 3 : #8852 - ldap sync output filter #

Patch Set 4 : #8852 - ldap sync output filter #

Patch Set 5 : #8852 - ldap sync output filter #

Total comments: 6

Patch Set 6 : #8852 - ldap sync output filter #

Total comments: 1

Patch Set 7 : #8852 - ldap sync output filter #

Patch Set 8 : #8852 - ldap sync output filter #

Total comments: 2

Patch Set 9 : #8852 - ldap sync output filter #

Total comments: 3

Patch Set 10 : #8852 - ldap sync output filter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -0 lines) Patch
A edit.sh View 1 2 3 4 5 6 7 8 9 1 chunk +32 lines, -0 lines 0 comments Download
A output.txt View 1 2 3 4 5 6 1 chunk +178 lines, -0 lines 0 comments Download

Messages

Total messages: 22
l.rosilio
4 months, 3 weeks ago (2018-04-25 11:42:38 UTC) #1
f.lopez
https://codereview.adblockplus.org/29761555/diff/29761556/edit.sh File edit.sh (right): https://codereview.adblockplus.org/29761555/diff/29761556/edit.sh#newcode1 edit.sh:1: #!/bin/bash please use /bin/sh instead of /bin/bash This way ...
4 months, 2 weeks ago (2018-05-04 01:50:54 UTC) #2
l.rosilio
On 2018/05/04 01:50:54, f.lopez wrote: > https://codereview.adblockplus.org/29761555/diff/29761556/edit.sh > File edit.sh (right): > > https://codereview.adblockplus.org/29761555/diff/29761556/edit.sh#newcode1 > ...
4 months, 1 week ago (2018-05-14 11:33:41 UTC) #3
l.rosilio
4 months, 1 week ago (2018-05-14 15:00:16 UTC) #4
f.lopez
I notice you don't write to `stdout(3)` (-q flag), but then you `echo(1)` some lines... ...
4 months, 1 week ago (2018-05-15 00:51:20 UTC) #5
l.rosilio
What makes 99% of the complexity in this script is that we don't want ALL ...
4 months, 1 week ago (2018-05-15 08:56:21 UTC) #6
l.rosilio
4 months, 1 week ago (2018-05-15 08:59:24 UTC) #7
l.rosilio
Expected output: all "->" lines + their previous line (in order to know for which ...
4 months, 1 week ago (2018-05-15 09:01:56 UTC) #8
f.lopez
On 2018/05/15 08:56:21, l.rosilio wrote: > What makes 99% of the complexity in this script ...
4 months ago (2018-05-22 01:47:39 UTC) #9
l.rosilio
4 months ago (2018-05-22 10:08:50 UTC) #10
l.rosilio
On 2018/05/22 01:47:39, f.lopez wrote: > You can use grep `-B` flag to get the ...
4 months ago (2018-05-22 10:10:43 UTC) #11
l.rosilio
3 months, 4 weeks ago (2018-05-23 12:15:41 UTC) #12
f.lopez
https://codereview.adblockplus.org/29761555/diff/29788555/edit.sh File edit.sh (right): https://codereview.adblockplus.org/29761555/diff/29788555/edit.sh#newcode3 edit.sh:3: # Filtering out uninformative output lines from the ldap-sync ...
3 months, 3 weeks ago (2018-05-29 21:18:49 UTC) #13
l.rosilio
3 months, 2 weeks ago (2018-06-05 13:59:46 UTC) #14
mathias
https://codereview.adblockplus.org/29761555/diff/29799591/edit.sh File edit.sh (right): https://codereview.adblockplus.org/29761555/diff/29799591/edit.sh#newcode12 edit.sh:12: *-\>*) Is there ever a case where we could ...
3 months, 2 weeks ago (2018-06-05 14:32:20 UTC) #15
l.rosilio
3 months, 2 weeks ago (2018-06-06 11:30:06 UTC) #16
l.rosilio
3 months, 2 weeks ago (2018-06-06 11:32:34 UTC) #17
mathias
https://codereview.adblockplus.org/29761555/diff/29800576/edit.sh File edit.sh (right): https://codereview.adblockplus.org/29761555/diff/29800576/edit.sh#newcode10 edit.sh:10: *Updating*|*Creating*) Please make the patterns a bit more specific, ...
3 months, 1 week ago (2018-06-11 14:10:57 UTC) #18
l.rosilio
3 months, 1 week ago (2018-06-12 14:50:37 UTC) #19
mathias
https://codereview.adblockplus.org/29761555/diff/29805564/edit.sh File edit.sh (right): https://codereview.adblockplus.org/29761555/diff/29805564/edit.sh#newcode10 edit.sh:10: case "$last_action" in As discussed, please replace the inner ...
3 months ago (2018-06-19 13:12:40 UTC) #20
l.rosilio
3 months ago (2018-06-20 12:32:29 UTC) #21
mathias
3 months ago (2018-06-20 12:54:07 UTC) #22
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5