Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(41)

Issue 29761555: #8852 - ldap sync output filter

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 4 days ago by l.rosilio
Modified:
5 days, 22 hours ago
Reviewers:
f.lopez
CC:
Fred, mathias
Visibility:
Public.

Description

#8852 - ldap sync output filter

Patch Set 1 #

Total comments: 5

Patch Set 2 : #8852 - ldap sync output filter #

Total comments: 8

Patch Set 3 : #8852 - ldap sync output filter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -0 lines) Patch
A edit.sh View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
A output.txt View 1 2 1 chunk +177 lines, -0 lines 0 comments Download

Messages

Total messages: 8
l.rosilio
3 weeks, 4 days ago (2018-04-25 11:42:38 UTC) #1
f.lopez
https://codereview.adblockplus.org/29761555/diff/29761556/edit.sh File edit.sh (right): https://codereview.adblockplus.org/29761555/diff/29761556/edit.sh#newcode1 edit.sh:1: #!/bin/bash please use /bin/sh instead of /bin/bash This way ...
2 weeks, 3 days ago (2018-05-04 01:50:54 UTC) #2
l.rosilio
On 2018/05/04 01:50:54, f.lopez wrote: > https://codereview.adblockplus.org/29761555/diff/29761556/edit.sh > File edit.sh (right): > > https://codereview.adblockplus.org/29761555/diff/29761556/edit.sh#newcode1 > ...
6 days, 19 hours ago (2018-05-14 11:33:41 UTC) #3
l.rosilio
6 days, 16 hours ago (2018-05-14 15:00:16 UTC) #4
f.lopez
I notice you don't write to `stdout(3)` (-q flag), but then you `echo(1)` some lines... ...
6 days, 6 hours ago (2018-05-15 00:51:20 UTC) #5
l.rosilio
What makes 99% of the complexity in this script is that we don't want ALL ...
5 days, 22 hours ago (2018-05-15 08:56:21 UTC) #6
l.rosilio
5 days, 22 hours ago (2018-05-15 08:59:24 UTC) #7
l.rosilio
5 days, 22 hours ago (2018-05-15 09:01:56 UTC) #8
Expected output: all "->" lines + their previous line (in order to know for
which user the change has been made), all error messages.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5