Issue 29769575: Issue 6320 - Add summary for adblock setting

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29769575: Issue 6320 - Add summary for adblock setting (Closed)

Created:
May 3, 2018, 12:56 p.m. by anton

Modified:
May 11, 2018, 9:47 a.m.

Reviewers:
diegocarloslima, jens

CC:
René Jeschke

Visibility:
Public.

Description

Issue 6320 - Add summary for adblock setting Replacement for https://codereview.adblockplus.org/29684564/

Patch Set 1 #

Created: May 3, 2018, 12:56 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -0 lines)			Patch
	M	libadblockplus-android-settings/res/values/adblock_settings_strings.xml	View		1 chunk	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

anton

Replacement for https://codereview.adblockplus.org/29684564/

May 3, 2018, 12:58 p.m. (2018-05-03 12:58:23 UTC) #1

jens

On 2018/05/03 12:58:23, anton wrote: > Replacement for https://codereview.adblockplus.org/29684564/ LGTM

May 3, 2018, 1:15 p.m. (2018-05-03 13:15:16 UTC) #2

diegocarloslima

On 2018/05/03 13:15:16, jens wrote: > On 2018/05/03 12:58:23, anton wrote: > > Replacement for ...

May 8, 2018, 10:30 p.m. (2018-05-08 22:30:19 UTC) #3

anton

May 11, 2018, 9:32 a.m. (2018-05-11 09:32:34 UTC) #4

On 2018/05/08 22:30:19, diegocarloslima wrote:
> On 2018/05/03 13:15:16, jens wrote:
> > On 2018/05/03 12:58:23, anton wrote:
> > > Replacement for https://codereview.adblockplus.org/29684564/
> > 
> > LGTM
> 
> It doesn't seem to me that those comments are actually related to ticket 6320.
> Are they? If not, I would suggest committing them as a Noissue commit (e.g.
> Noissue - Adding string comments). Apart from that, LGTM

Yes, they are exactly summary for adblock settings

Expand All Messages | Collapse All Messages