Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(404)

Issue 29784577: Issue 6205 - Upload artifacs to maven repository (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 10 months ago by diegocarloslima
Modified:
1 year, 8 months ago
Reviewers:
jens, anton
Visibility:
Public.

Description

Issue 6205 - Upload artifacs to maven repository

Patch Set 1 #

Total comments: 6

Patch Set 2 : Several adjustments #

Total comments: 7

Patch Set 3 : Adjustments regarding comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -112 lines) Patch
M README.md View 1 4 chunks +35 lines, -5 lines 0 comments Download
M adblock-android-settings/build.gradle View 1 1 chunk +17 lines, -12 lines 0 comments Download
M adblock-android-tests/build.gradle View 1 1 chunk +7 lines, -25 lines 0 comments Download
M adblock-android-webview/build.gradle View 1 1 chunk +16 lines, -11 lines 0 comments Download
M adblock-android-webviewapp/build.gradle View 1 1 chunk +5 lines, -22 lines 0 comments Download
M adblock-android/AndroidManifest.xml View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M adblock-android/build.gradle View 1 2 chunks +19 lines, -4 lines 0 comments Download
M adblock-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build.gradle View 1 1 chunk +18 lines, -31 lines 0 comments Download
M gradle/wrapper/gradle-wrapper.properties View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12
diegocarloslima
https://codereview.adblockplus.org/29784577/diff/29784578/adblock-android/AndroidManifest.xml File adblock-android/AndroidManifest.xml (right): https://codereview.adblockplus.org/29784577/diff/29784578/adblock-android/AndroidManifest.xml#newcode9 adblock-android/AndroidManifest.xml:9: <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/> The lack of this permission was causing ...
1 year, 10 months ago (2018-05-17 13:45:48 UTC) #1
anton
https://codereview.adblockplus.org/29784577/diff/29784578/adblock-android/build.gradle File adblock-android/build.gradle (right): https://codereview.adblockplus.org/29784577/diff/29784578/adblock-android/build.gradle#newcode72 adblock-android/build.gradle:72: } I think we need to add section to ...
1 year, 10 months ago (2018-05-21 19:50:51 UTC) #2
diegocarloslima
https://codereview.adblockplus.org/29784577/diff/29784578/adblock-android/build.gradle File adblock-android/build.gradle (right): https://codereview.adblockplus.org/29784577/diff/29784578/adblock-android/build.gradle#newcode72 adblock-android/build.gradle:72: } On 2018/05/21 19:50:51, anton wrote: > I think ...
1 year, 10 months ago (2018-06-04 20:41:20 UTC) #3
anton
On 2018/06/04 20:41:20, diegocarloslima wrote: > https://codereview.adblockplus.org/29784577/diff/29784578/adblock-android/build.gradle > File adblock-android/build.gradle (right): > > https://codereview.adblockplus.org/29784577/diff/29784578/adblock-android/build.gradle#newcode72 > ...
1 year, 9 months ago (2018-07-02 10:06:32 UTC) #4
diegocarloslima
On 2018/07/02 10:06:32, anton wrote: > On 2018/06/04 20:41:20, diegocarloslima wrote: > > > https://codereview.adblockplus.org/29784577/diff/29784578/adblock-android/build.gradle ...
1 year, 9 months ago (2018-07-03 09:22:06 UTC) #5
anton
On 2018/07/03 09:22:06, diegocarloslima wrote: > On 2018/07/02 10:06:32, anton wrote: > > On 2018/06/04 ...
1 year, 9 months ago (2018-07-03 09:51:04 UTC) #6
diegocarloslima
https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java File adblock-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java (right): https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java#newcode87 adblock-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java:87: * @param urlToResourceIdMap map URL android resource id for ...
1 year, 8 months ago (2018-07-09 16:01:01 UTC) #7
anton
https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/AndroidManifest.xml File adblock-android/AndroidManifest.xml (right): https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/AndroidManifest.xml#newcode9 adblock-android/AndroidManifest.xml:9: <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/> Unrelated change. It's mentioned in README that ...
1 year, 8 months ago (2018-07-10 09:51:39 UTC) #8
jens
https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/AndroidManifest.xml File adblock-android/AndroidManifest.xml (right): https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/AndroidManifest.xml#newcode9 adblock-android/AndroidManifest.xml:9: <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/> I always prefer to not add permissions ...
1 year, 8 months ago (2018-07-10 10:08:10 UTC) #9
diegocarloslima
https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/AndroidManifest.xml File adblock-android/AndroidManifest.xml (right): https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/AndroidManifest.xml#newcode9 adblock-android/AndroidManifest.xml:9: <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/> On 2018/07/10 10:08:10, jens wrote: > I ...
1 year, 8 months ago (2018-07-10 12:26:03 UTC) #10
anton
On 2018/07/10 12:26:03, diegocarloslima wrote: > https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/AndroidManifest.xml > File adblock-android/AndroidManifest.xml (right): > > https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/AndroidManifest.xml#newcode9 > ...
1 year, 8 months ago (2018-07-10 13:34:01 UTC) #11
jens
1 year, 8 months ago (2018-07-10 13:47:58 UTC) #12
On 2018/07/10 13:34:01, anton wrote:
> On 2018/07/10 12:26:03, diegocarloslima wrote:
> >
>
https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/And...
> > File adblock-android/AndroidManifest.xml (right):
> > 
> >
>
https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/And...
> > adblock-android/AndroidManifest.xml:9: <uses-permission
> > android:name="android.permission.ACCESS_NETWORK_STATE"/>
> > On 2018/07/10 10:08:10, jens wrote:
> > > I always prefer to not add permissions in the library, but to add them
> myself
> > in
> > > the app project.
> > 
> > As explained through IRC, this change is not unrelated, since the
> bintrayUpload
> > task runs the lint task, which throws an error due to this missing
permission.
> I
> > will also add the other permission, to make it consistent
> > 
> >
>
https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/src...
> > File
> >
>
adblock-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java
> > (right):
> > 
> >
>
https://codereview.adblockplus.org/29784577/diff/29825661/adblock-android/src...
> >
>
adblock-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java:87:
> > * @param urlToResourceIdMap map URL android resource id for preloaded
> > subscriptions
> > On 2018/07/10 10:08:10, jens wrote:
> > > the word "to" is missing.
> > 
> > I will add the `to` word
> 
> LGTM

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5