Issue 6720 - Do not package the qunit test files.

metadata.chrome

Index: metadata.chrome
===================================================================
--- a/metadata.chrome
+++ b/metadata.chrome
@@ -151,21 +151,16 @@
   lib/cssInjection.js
   adblockplusui/messageResponder.js
 include.preload.js =
   include.preload.js
   inject.preload.js
 include.postload.js =
   subscriptionLink.postload.js
   composer.postload.js
-qunit/tests.js =

[tlucas, 2018/06/04 09:52:27]

This would fix the ticket, but it would also break unit-testing in the devenv
builds.

FWIW i think the issue should be handled in `buildtools`, rather than in
`adblockpluschrome`

[hub, 2018/06/04 12:21:18]

It actually fixes the unit testing in devenv, which is how I arrived here. 
packagerChrome.py line 209 it add the second qunit/tests.js bundle to the
webpack configuration, generate it a second time. And from what I could see, the
second one might be overwritten by the first one. Oh yeah because I was adding a
test at that point, so that's how I noticed.

The alternative would be to remove that block in packagerChrome, but then we'd
ship the qunit tests in the release. (and we'd have to add new tests in the
manifest - which is not a problem, just a change)

-  qunit/common.js
-  qunit/tests/prefs.js
-  qunit/tests/url.js
-  qunit/tests/cssEscaping.js
 
 [import_locales]
 adblockplusui/locale/*/antiadblockInit.json = *
 adblockplusui/locale/*/common.json = *
 adblockplusui/locale/*/desktop-options.json = *
 adblockplusui/locale/*/firstRun.json = *
 adblockplusui/locale/*/issue-reporter.json = *
 adblockplusui/locale/*/updates.json = *