Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29800600: Fixes #93 - Updated privacy policy for adblock.ai (Closed)

Created:
June 6, 2018, 5:03 p.m. by juliandoucette
Modified:
June 7, 2018, 5:24 p.m.
Reviewers:
tamara, j.nink, ire
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Fixes #93 - Updated privacy policy for adblock.ai https://gitlab.com/eyeo/websites/web.adblockplus.org/issues/93

Patch Set 1 #

Total comments: 10

Patch Set 2 : Addressed #3-6 #

Patch Set 3 : Added translations #

Patch Set 4 : Addressed #10-16 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -14 lines) Patch
M locales/de/privacy.json View 1 2 3 5 chunks +40 lines, -1 line 0 comments Download
M locales/fr/privacy.json View 1 2 3 10 chunks +50 lines, -11 lines 0 comments Download
M pages/privacy.md View 1 2 3 4 chunks +25 lines, -2 lines 0 comments Download

Messages

Total messages: 20
juliandoucette
June 6, 2018, 5:03 p.m. (2018-06-06 17:03:58 UTC) #1
juliandoucette
Hey Ire, Can you have a quick look at this please? I'll get to translations ...
June 6, 2018, 5:06 p.m. (2018-06-06 17:06:27 UTC) #2
ire
Thanks Julian, comments below https://codereview.adblockplus.org/29800600/diff/29800601/pages/privacy.md File pages/privacy.md (right): https://codereview.adblockplus.org/29800600/diff/29800601/pages/privacy.md#newcode359 pages/privacy.md:359: ##### {{ adblock-ai-heading[heading] At adblock.ai ...
June 6, 2018, 5:43 p.m. (2018-06-06 17:43:55 UTC) #3
juliandoucette
https://codereview.adblockplus.org/29800600/diff/29800601/pages/privacy.md File pages/privacy.md (right): https://codereview.adblockplus.org/29800600/diff/29800601/pages/privacy.md#newcode359 pages/privacy.md:359: ##### {{ adblock-ai-heading[heading] At adblock.ai }} {: #adblock-ai } ...
June 6, 2018, 5:49 p.m. (2018-06-06 17:49:02 UTC) #4
ire
https://codereview.adblockplus.org/29800600/diff/29800601/pages/privacy.md File pages/privacy.md (right): https://codereview.adblockplus.org/29800600/diff/29800601/pages/privacy.md#newcode359 pages/privacy.md:359: ##### {{ adblock-ai-heading[heading] At adblock.ai }} {: #adblock-ai } ...
June 6, 2018, 6:23 p.m. (2018-06-06 18:23:19 UTC) #5
juliandoucette
New Patchset up soon. https://codereview.adblockplus.org/29800600/diff/29800601/pages/privacy.md File pages/privacy.md (right): https://codereview.adblockplus.org/29800600/diff/29800601/pages/privacy.md#newcode359 pages/privacy.md:359: ##### {{ adblock-ai-heading[heading] At adblock.ai ...
June 6, 2018, 6:30 p.m. (2018-06-06 18:30:36 UTC) #6
juliandoucette
> New Patchset up soon. Done.
June 6, 2018, 6:35 p.m. (2018-06-06 18:35:05 UTC) #7
juliandoucette
Detail: Tamara added non-breaking spaces to some of her french translations of this page since ...
June 6, 2018, 7:14 p.m. (2018-06-06 19:14:43 UTC) #8
juliandoucette
CC Judith & Tamara I have uploaded and downloaded these translations to/from crowdin (because of ...
June 6, 2018, 7:16 p.m. (2018-06-06 19:16:54 UTC) #9
j.nink
On 2018/06/06 19:16:54, juliandoucette wrote: > CC Judith & Tamara > > I have uploaded ...
June 7, 2018, 7:15 a.m. (2018-06-07 07:15:36 UTC) #10
tamara
On 2018/06/07 07:15:36, j.nink wrote: > On 2018/06/06 19:16:54, juliandoucette wrote: > > CC Judith ...
June 7, 2018, 10:09 a.m. (2018-06-07 10:09:26 UTC) #11
juliandoucette
On 2018/06/07 10:09:26, tamara wrote: > More than happy to. How shall I add changes? ...
June 7, 2018, 11:11 a.m. (2018-06-07 11:11:52 UTC) #12
juliandoucette
@Judith, @Tamara These might help: French: https://drive.google.com/open?id=1G0IF4QhZHgopXJLgkWLrlYlSqYLr2u3n German: https://drive.google.com/open?id=1kkjkJmY2TTLMTinKhvfcB9zOx2Qlrfqx You should be able to unzip ...
June 7, 2018, 11:40 a.m. (2018-06-07 11:40:20 UTC) #13
tamara
On 2018/06/07 11:40:20, juliandoucette wrote: > @Judith, @Tamara > > These might help: > > ...
June 7, 2018, 12:43 p.m. (2018-06-07 12:43:56 UTC) #14
j.nink
On 2018/06/07 10:09:26, tamara wrote: > On 2018/06/07 07:15:36, j.nink wrote: > > On 2018/06/06 ...
June 7, 2018, 1:01 p.m. (2018-06-07 13:01:35 UTC) #15
j.nink
On 2018/06/07 07:15:36, j.nink wrote: > On 2018/06/06 19:16:54, juliandoucette wrote: > > CC Judith ...
June 7, 2018, 1:02 p.m. (2018-06-07 13:02:14 UTC) #16
ire
Implementation LGTM
June 7, 2018, 2:54 p.m. (2018-06-07 14:54:11 UTC) #17
juliandoucette
I've updated the translations in my latest Patchset. Judith & Tamara does this LGTY? Also: ...
June 7, 2018, 3:36 p.m. (2018-06-07 15:36:11 UTC) #18
j.nink
On 2018/06/07 15:36:11, juliandoucette wrote: > I've updated the translations in my latest Patchset. > ...
June 7, 2018, 4:51 p.m. (2018-06-07 16:51:11 UTC) #19
juliandoucette
June 7, 2018, 5:23 p.m. (2018-06-07 17:23:31 UTC) #20
On 2018/06/07 16:51:11, j.nink wrote:
> Great, thanks Julian. LGTM. Yes, immediately pushing would be great (Facebook
> has approved the bot today. Thanks

Done https://hg.adblockplus.org/web.adblockplus.org/rev/5537d41bee54.

Detail: I also fixed a couple other translation issues:
- https://hg.adblockplus.org/web.adblockplus.org/rev/da1204a26e40
- https://hg.adblockplus.org/web.adblockplus.org/rev/1810d4fce6cc

Powered by Google App Engine
This is Rietveld