Fixes #93 - Updated privacy policy for adblock.ai

Fixes #93 - Updated privacy policy for adblock.ai

https://gitlab.com/eyeo/websites/web.adblockplus.org/issues/93

[juliandoucette, 2018-06-06 17:06:27]

Hey Ire,

Can you have a quick look at this please?

I'll get to translations shortly after.

[ire, 2018-06-06 17:43:55]

Thanks Julian, comments below

https://codereview.adblockplus.org/29800600/diff/29800601/pages/privacy.md
File pages/privacy.md (right):

https://codereview.adblockplus.org/29800600/diff/29800601/pages/privacy.md#ne...
pages/privacy.md:359: ##### {{ adblock-ai-heading[heading] At adblock.ai }} {:
#adblock-ai }
I think this is supposed to be an h5 (same level as the Cookies heading)

https://codereview.adblockplus.org/29800600/diff/29800601/pages/privacy.md#ne...
pages/privacy.md:363: ###### {{ facebook-messenge-integration-heading[heading]
Facebook messenger integration }} {: #facebook-messenger-integration }
And this should be h6, although it's just underlined in the spec

https://codereview.adblockplus.org/29800600/diff/29800601/pages/privacy.md#ne...
pages/privacy.md:363: ###### {{ facebook-messenge-integration-heading[heading]
Facebook messenger integration }} {: #facebook-messenger-integration }
Typo: "facebook-messenge"

[juliandoucette, 2018-06-06 17:49:02]

https://codereview.adblockplus.org/29800600/diff/29800601/pages/privacy.md
File pages/privacy.md (right):

https://codereview.adblockplus.org/29800600/diff/29800601/pages/privacy.md#ne...
pages/privacy.md:359: ##### {{ adblock-ai-heading[heading] At adblock.ai }} {:
#adblock-ai }
On 2018/06/06 17:43:55, ire wrote:
> I think this is supposed to be an h5 (same level as the Cookies heading)

It is H5?

https://codereview.adblockplus.org/29800600/diff/29800601/pages/privacy.md#ne...
pages/privacy.md:363: ###### {{ facebook-messenge-integration-heading[heading]
Facebook messenger integration }} {: #facebook-messenger-integration }
On 2018/06/06 17:43:55, ire wrote:
> And this should be h6, although it's just underlined in the spec

It is h6?

https://codereview.adblockplus.org/29800600/diff/29800601/pages/privacy.md#ne...
pages/privacy.md:363: ###### {{ facebook-messenge-integration-heading[heading]
Facebook messenger integration }} {: #facebook-messenger-integration }
On 2018/06/06 17:43:55, ire wrote:
> Typo: "facebook-messenge"

Acknowledged.

[ire, 2018-06-06 18:23:19]

https://codereview.adblockplus.org/29800600/diff/29800601/pages/privacy.md
File pages/privacy.md (right):

https://codereview.adblockplus.org/29800600/diff/29800601/pages/privacy.md#ne...
pages/privacy.md:359: ##### {{ adblock-ai-heading[heading] At adblock.ai }} {:
#adblock-ai }
On 2018/06/06 17:49:02, juliandoucette wrote:
> On 2018/06/06 17:43:55, ire wrote:
> > I think this is supposed to be an h5 (same level as the Cookies heading)
> 
> It is H5?

Sorry I meant h6. The same level as the Cookies heading above

https://codereview.adblockplus.org/29800600/diff/29800601/pages/privacy.md#ne...
pages/privacy.md:363: ###### {{ facebook-messenge-integration-heading[heading]
Facebook messenger integration }} {: #facebook-messenger-integration }
On 2018/06/06 17:49:02, juliandoucette wrote:
> On 2018/06/06 17:43:55, ire wrote:
> > And this should be h6, although it's just underlined in the spec
> 
> It is h6?

Since the above is h6, then this can't be a heading I guess?

[juliandoucette, 2018-06-06 18:30:36]

New Patchset up soon.

https://codereview.adblockplus.org/29800600/diff/29800601/pages/privacy.md
File pages/privacy.md (right):

https://codereview.adblockplus.org/29800600/diff/29800601/pages/privacy.md#ne...
pages/privacy.md:359: ##### {{ adblock-ai-heading[heading] At adblock.ai }} {:
#adblock-ai }
On 2018/06/06 18:23:19, ire wrote:
> On 2018/06/06 17:49:02, juliandoucette wrote:
> > On 2018/06/06 17:43:55, ire wrote:
> > > I think this is supposed to be an h5 (same level as the Cookies heading)
> > 
> > It is H5?
> 
> Sorry I meant h6. The same level as the Cookies heading above

Ah, thanks. I miscounted.

https://codereview.adblockplus.org/29800600/diff/29800601/pages/privacy.md#ne...
pages/privacy.md:363: ###### {{ facebook-messenge-integration-heading[heading]
Facebook messenger integration }} {: #facebook-messenger-integration }
On 2018/06/06 18:23:19, ire wrote:
> Since the above is h6, then this can't be a heading I guess?

I guess :-1:

[juliandoucette, 2018-06-06 18:35:05]

> New Patchset up soon.

Done.

[juliandoucette, 2018-06-06 19:14:43]

Detail: Tamara added non-breaking spaces to some of her french translations of
this page since we have last synced and there is no easy way for me to exclude
them. They are harmless AFAICT - so I have not manually removed them.

[juliandoucette, 2018-06-06 19:16:54]

CC Judith & Tamara

I have uploaded and downloaded these translations to/from crowdin (because of
the urgency of this issue). Will you please help me review them?

[j.nink, 2018-06-07 07:15:36]

On 2018/06/06 19:16:54, juliandoucette wrote:
> CC Judith & Tamara
> 
> I have uploaded and downloaded these translations to/from crowdin (because of
> the urgency of this issue). Will you please help me review them?

More than happy to. How shall I add changes? In crowdin directly? I found one
small mistake in the German version, everything else LGTM

[tamara, 2018-06-07 10:09:26]

On 2018/06/07 07:15:36, j.nink wrote:
> On 2018/06/06 19:16:54, juliandoucette wrote:
> > CC Judith & Tamara
> > 
> > I have uploaded and downloaded these translations to/from crowdin (because
of
> > the urgency of this issue). Will you please help me review them?
> 
> More than happy to. How shall I add changes? In crowdin directly? I found one
> small mistake in the German version, everything else LGTM

Thanks Julian.

I corrected a couple of things for French and added non-breakable spaces where
needed.

@Judith: I could do the same for German in regards to the spaces if you wanted
me to.
Btw, I've noticed that "Cookie" is spelled in singular in one instance when it
should be plural.
Also, shouldn't it be "Facebook-Datenschutzerklärung" instead of "Facebooks
Datenschutzerklärung" in order to keep consistency with the rest of the text
when mentioning the privacy policies for other companies?  :)

[juliandoucette, 2018-06-07 11:11:52]

On 2018/06/07 10:09:26, tamara wrote:

> More than happy to. How shall I add changes? In crowdin directly? I found one
> small mistake in the German version, everything else Looks good to me.

Please make changes in crowdin and then notify me afterwards so that I can
update my review.

Thank you!

[juliandoucette, 2018-06-07 11:40:20]

@Judith, @Tamara

These might help:

French:
https://drive.google.com/open?id=1G0IF4QhZHgopXJLgkWLrlYlSqYLr2u3n

German:
https://drive.google.com/open?id=1kkjkJmY2TTLMTinKhvfcB9zOx2Qlrfqx

You should be able to unzip them and open them in your browser.

If they help a lot then I can export pages for you like this more often (until
we get a staging server that can do it automatically).

[tamara, 2018-06-07 12:43:56]

On 2018/06/07 11:40:20, juliandoucette wrote:
> @Judith, @Tamara
> 
> These might help:
> 
> French:
> https://drive.google.com/open?id=1G0IF4QhZHgopXJLgkWLrlYlSqYLr2u3n
> 
> German:
> https://drive.google.com/open?id=1kkjkJmY2TTLMTinKhvfcB9zOx2Qlrfqx
> 
> You should be able to unzip them and open them in your browser.
> 
> If they help a lot then I can export pages for you like this more often (until
> we get a staging server that can do it automatically).

Thanks Julian. It did help me already also a couple of weeks ago.  :)

French should be ready, btw. Just waiting for Judith to see how she'd like to
proceed.  :)

[j.nink, 2018-06-07 13:01:35]

On 2018/06/07 10:09:26, tamara wrote:
> On 2018/06/07 07:15:36, j.nink wrote:
> > On 2018/06/06 19:16:54, juliandoucette wrote:
> > > CC Judith & Tamara
> > > 
> > > I have uploaded and downloaded these translations to/from crowdin (because
> of
> > > the urgency of this issue). Will you please help me review them?
> > 
> > More than happy to. How shall I add changes? In crowdin directly? I found
one
> > small mistake in the German version, everything else LGTM
> 
> Thanks Julian.
> 
> I corrected a couple of things for French and added non-breakable spaces where
> needed.
> 
> @Judith: I could do the same for German in regards to the spaces if you wanted
> me to.
> Btw, I've noticed that "Cookie" is spelled in singular in one instance when it
> should be plural.
> Also, shouldn't it be "Facebook-Datenschutzerklärung" instead of "Facebooks
> Datenschutzerklärung" in order to keep consistency with the rest of the text
> when mentioning the privacy policies for other companies?  :)

Hi Tamara:
> Btw, I've noticed that "Cookie" is spelled in singular in one instance when it
> should be plural.
Nope: singular and plural differentiation make sense in this context.

> Also, shouldn't it be "Facebook-Datenschutzerklärung" instead of "Facebooks
> Datenschutzerklärung" in order to keep consistency with the rest of the text
> when mentioning the privacy policies for other companies?  :)
Same, Facebook-Datenschutzerklärung would be weird in this context

[j.nink, 2018-06-07 13:02:14]

On 2018/06/07 07:15:36, j.nink wrote:
> On 2018/06/06 19:16:54, juliandoucette wrote:
> > CC Judith & Tamara
> > 
> > I have uploaded and downloaded these translations to/from crowdin (because
of
> > the urgency of this issue). Will you please help me review them?
> 
> More than happy to. How shall I add changes? In crowdin directly? I found one
> small mistake in the German version, everything else LGTM

@julian @Tamara:
done, changed the one word in crowdin. You can go ahead from my end

[ire, 2018-06-07 14:54:11]

Implementation LGTM

[juliandoucette, 2018-06-07 15:36:11]

I've updated the translations in my latest Patchset. 

Judith & Tamara does this LGTY?

Also: Should I publish this immediately after you approve or wait for adblock.ai
to launch?

[j.nink, 2018-06-07 16:51:11]

On 2018/06/07 15:36:11, juliandoucette wrote:
> I've updated the translations in my latest Patchset. 
> 
> Judith & Tamara does this LGTY?
> 
> Also: Should I publish this immediately after you approve or wait for
adblock.ai
> to launch?

Great, thanks Julian. LGTM. Yes, immediately pushing would be great (Facebook
has approved the bot today. Thanks

[juliandoucette, 2018-06-07 17:23:31]

On 2018/06/07 16:51:11, j.nink wrote:
> Great, thanks Julian. LGTM. Yes, immediately pushing would be great (Facebook
> has approved the bot today. Thanks

Done https://hg.adblockplus.org/web.adblockplus.org/rev/5537d41bee54.

Detail: I also fixed a couple other translation issues:
- https://hg.adblockplus.org/web.adblockplus.org/rev/da1204a26e40
- https://hg.adblockplus.org/web.adblockplus.org/rev/1810d4fce6cc