Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

Issue 29801558: Issue 6737 - Use String.includes instead of String.indexOf (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 3 months ago by Manish Jethani
Modified:
1 year, 3 months ago
Reviewers:
kzar, sergei
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Replace more instances #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M lib/common.js View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/downloader.js View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/filterClasses.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Manish Jethani
1 year, 3 months ago (2018-06-07 09:27:58 UTC) #1
Manish Jethani
Patch Set 1 Patch Set 2: Replace more instances Please see issue #6737 description.
1 year, 3 months ago (2018-06-07 09:52:49 UTC) #2
Manish Jethani
By the way I could not find any such instances in the test directory.
1 year, 3 months ago (2018-06-07 09:55:18 UTC) #3
kzar
1 year, 3 months ago (2018-06-07 09:59:10 UTC) #4
Thanks for taking the time to do this, LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5