Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(437)

Issue 29808587: Issue 6717 - Part 1: run eslint through npm (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months ago by hub
Modified:
2 months ago
Reviewers:
kzar, Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Issue 6717 - Part 1: run eslint through npm

Patch Set 1 #

Patch Set 2 : Forgot the hgignore and gitignore #

Total comments: 3

Patch Set 3 : Use eslint4 and eyeo eslint 2.0.0. Rename task to "lint" #

Total comments: 6

Patch Set 4 : Use eslint5. Fix eslint error. #

Total comments: 4

Patch Set 5 : Require eslint-config-eyeo 2.1.0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -4 lines) Patch
M .gitignore View 1 1 chunk +1 line, -0 lines 0 comments Download
M .hgignore View 1 1 chunk +1 line, -0 lines 0 comments Download
M README.md View 1 2 3 4 1 chunk +9 lines, -4 lines 0 comments Download
M ext/background.js View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A package.json View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 16
hub
4 months ago (2018-06-15 20:13:43 UTC) #1
hub
This is part 1 towards running the test doing `npm test`. After fixing a few ...
4 months ago (2018-06-15 20:21:01 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29808587/diff/29808591/package.json File package.json (right): https://codereview.adblockplus.org/29808587/diff/29808591/package.json#newcode11 package.json:11: "eslint": "eslint *.js lib/ qunit/ ext/ chrome/", For reference, ...
4 months ago (2018-06-15 21:34:26 UTC) #3
hub
https://codereview.adblockplus.org/29808587/diff/29808591/package.json File package.json (right): https://codereview.adblockplus.org/29808587/diff/29808591/package.json#newcode11 package.json:11: "eslint": "eslint *.js lib/ qunit/ ext/ chrome/", On 2018/06/15 ...
4 months ago (2018-06-17 23:06:09 UTC) #4
hub
https://codereview.adblockplus.org/29808587/diff/29808591/package.json File package.json (right): https://codereview.adblockplus.org/29808587/diff/29808591/package.json#newcode11 package.json:11: "eslint": "eslint *.js lib/ qunit/ ext/ chrome/", On 2018/06/17 ...
4 months ago (2018-06-18 12:15:57 UTC) #5
hub
the task is now "lint" and not "eslint". We require eslint 4. (the migration to ...
3 months, 1 week ago (2018-07-13 14:15:29 UTC) #6
Sebastian Noack
https://codereview.adblockplus.org/29808587/diff/29829574/package.json File package.json (right): https://codereview.adblockplus.org/29808587/diff/29829574/package.json#newcode7 package.json:7: "eslint": "^4.19.0", We want to update to ESLint 5, ...
3 months, 1 week ago (2018-07-13 15:04:08 UTC) #7
hub
https://codereview.adblockplus.org/29808587/diff/29829574/package.json File package.json (right): https://codereview.adblockplus.org/29808587/diff/29829574/package.json#newcode7 package.json:7: "eslint": "^4.19.0", On 2018/07/13 15:04:08, Sebastian Noack wrote: > ...
3 months, 1 week ago (2018-07-13 15:05:47 UTC) #8
Sebastian Noack
https://codereview.adblockplus.org/29808587/diff/29829574/package.json File package.json (right): https://codereview.adblockplus.org/29808587/diff/29829574/package.json#newcode7 package.json:7: "eslint": "^4.19.0", On 2018/07/13 15:05:47, hub wrote: > On ...
3 months, 1 week ago (2018-07-13 15:08:26 UTC) #9
hub
https://codereview.adblockplus.org/29808587/diff/29829574/package.json File package.json (right): https://codereview.adblockplus.org/29808587/diff/29829574/package.json#newcode7 package.json:7: "eslint": "^4.19.0", On 2018/07/13 15:08:26, Sebastian Noack wrote: > ...
3 months, 1 week ago (2018-07-13 16:12:43 UTC) #10
hub
We are actually blocked by this review https://codereview.adblockplus.org/29829605/ and the matching upload to npm.
2 months, 1 week ago (2018-08-07 21:14:45 UTC) #11
kzar
https://codereview.adblockplus.org/29808587/diff/29829596/README.md File README.md (right): https://codereview.adblockplus.org/29808587/diff/29829596/README.md#newcode93 README.md:93: You can lint the code using [ESLint](http://eslint.org). Would you ...
2 months, 1 week ago (2018-08-08 11:15:20 UTC) #12
hub
https://codereview.adblockplus.org/29808587/diff/29829596/README.md File README.md (right): https://codereview.adblockplus.org/29808587/diff/29829596/README.md#newcode93 README.md:93: You can lint the code using [ESLint](http://eslint.org). On 2018/08/08 ...
2 months ago (2018-08-14 11:37:04 UTC) #13
Sebastian Noack
https://codereview.adblockplus.org/29808587/diff/29829574/package.json File package.json (right): https://codereview.adblockplus.org/29808587/diff/29829574/package.json#newcode7 package.json:7: "eslint": "^4.19.0", On 2018/07/13 15:04:08, Sebastian Noack wrote: > ...
2 months ago (2018-08-14 19:16:56 UTC) #14
hub
https://codereview.adblockplus.org/29808587/diff/29829574/package.json File package.json (right): https://codereview.adblockplus.org/29808587/diff/29829574/package.json#newcode7 package.json:7: "eslint": "^4.19.0", On 2018/08/14 19:16:55, Sebastian Noack wrote: > ...
2 months ago (2018-08-14 19:35:16 UTC) #15
Sebastian Noack
2 months ago (2018-08-14 19:54:09 UTC) #16
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5