Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(195)

Issue 29808587: Issue 6717 - Part 1: run eslint through npm

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 4 weeks ago by hub
Modified:
5 days, 20 hours ago
Reviewers:
kzar, Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Issue 6717 - Part 1: run eslint through npm

Patch Set 1 #

Patch Set 2 : Forgot the hgignore and gitignore #

Total comments: 3

Patch Set 3 : Use eslint4 and eyeo eslint 2.0.0. Rename task to "lint" #

Total comments: 4

Patch Set 4 : Use eslint5. Fix eslint error. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M .gitignore View 1 1 chunk +1 line, -0 lines 0 comments Download
M .hgignore View 1 1 chunk +1 line, -0 lines 0 comments Download
M README.md View 1 2 1 chunk +4 lines, -4 lines 1 comment Download
M ext/background.js View 1 2 3 1 chunk +2 lines, -0 lines 1 comment Download
A package.json View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 12
hub
1 month, 4 weeks ago (2018-06-15 20:13:43 UTC) #1
hub
This is part 1 towards running the test doing `npm test`. After fixing a few ...
1 month, 4 weeks ago (2018-06-15 20:21:01 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29808587/diff/29808591/package.json File package.json (right): https://codereview.adblockplus.org/29808587/diff/29808591/package.json#newcode11 package.json:11: "eslint": "eslint *.js lib/ qunit/ ext/ chrome/", For reference, ...
1 month, 4 weeks ago (2018-06-15 21:34:26 UTC) #3
hub
https://codereview.adblockplus.org/29808587/diff/29808591/package.json File package.json (right): https://codereview.adblockplus.org/29808587/diff/29808591/package.json#newcode11 package.json:11: "eslint": "eslint *.js lib/ qunit/ ext/ chrome/", On 2018/06/15 ...
1 month, 3 weeks ago (2018-06-17 23:06:09 UTC) #4
hub
https://codereview.adblockplus.org/29808587/diff/29808591/package.json File package.json (right): https://codereview.adblockplus.org/29808587/diff/29808591/package.json#newcode11 package.json:11: "eslint": "eslint *.js lib/ qunit/ ext/ chrome/", On 2018/06/17 ...
1 month, 3 weeks ago (2018-06-18 12:15:57 UTC) #5
hub
the task is now "lint" and not "eslint". We require eslint 4. (the migration to ...
1 month ago (2018-07-13 14:15:29 UTC) #6
Sebastian Noack
https://codereview.adblockplus.org/29808587/diff/29829574/package.json File package.json (right): https://codereview.adblockplus.org/29808587/diff/29829574/package.json#newcode7 package.json:7: "eslint": "^4.19.0", We want to update to ESLint 5, ...
1 month ago (2018-07-13 15:04:08 UTC) #7
hub
https://codereview.adblockplus.org/29808587/diff/29829574/package.json File package.json (right): https://codereview.adblockplus.org/29808587/diff/29829574/package.json#newcode7 package.json:7: "eslint": "^4.19.0", On 2018/07/13 15:04:08, Sebastian Noack wrote: > ...
1 month ago (2018-07-13 15:05:47 UTC) #8
Sebastian Noack
https://codereview.adblockplus.org/29808587/diff/29829574/package.json File package.json (right): https://codereview.adblockplus.org/29808587/diff/29829574/package.json#newcode7 package.json:7: "eslint": "^4.19.0", On 2018/07/13 15:05:47, hub wrote: > On ...
1 month ago (2018-07-13 15:08:26 UTC) #9
hub
https://codereview.adblockplus.org/29808587/diff/29829574/package.json File package.json (right): https://codereview.adblockplus.org/29808587/diff/29829574/package.json#newcode7 package.json:7: "eslint": "^4.19.0", On 2018/07/13 15:08:26, Sebastian Noack wrote: > ...
1 month ago (2018-07-13 16:12:43 UTC) #10
hub
We are actually blocked by this review https://codereview.adblockplus.org/29829605/ and the matching upload to npm.
6 days, 14 hours ago (2018-08-07 21:14:45 UTC) #11
kzar
6 days ago (2018-08-08 11:15:20 UTC) #12
https://codereview.adblockplus.org/29808587/diff/29829596/README.md
File README.md (right):

https://codereview.adblockplus.org/29808587/diff/29829596/README.md#newcode93
README.md:93: You can lint the code using [ESLint](http://eslint.org).
Would you mind adding a link to our configuration here?

https://codereview.adblockplus.org/29808587/diff/29829596/ext/background.js
File ext/background.js (right):

https://codereview.adblockplus.org/29808587/diff/29829596/ext/background.js#n...
ext/background.js:99: return undefined;
This looks like an unrelated change? If not could you explain it?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5