Unified Diff: src/Utils.cpp
Issue 29809555:
Issue #6526 - pass v8::Isolate to more functions because old approach is deprecated (Closed)
Base URL: https://github.com/adblockplus/libadblockplus@4d9bcc12e77369cbc4bc04bace9a3e7fa03de17b
Patch Set:
Created June 18, 2018, 10:22 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« src/FileSystemJsObject.cpp ('K')
|
« src/Utils.h ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: src/Utils.cpp |
| diff --git a/src/Utils.cpp b/src/Utils.cpp |
| index b084ffba7a4bc72218dfb2080d00b9eaae09bdec..3c78c61c1d16a9eaf96f7868e8589bfa9207de31 100644 |
| --- a/src/Utils.cpp |
| +++ b/src/Utils.cpp |
| @@ -26,18 +26,18 @@ |
| using namespace AdblockPlus; |
| -std::string Utils::FromV8String(const v8::Local<v8::Value>& value) |
| +std::string Utils::FromV8String(v8::Isolate* isolate, const v8::Local<v8::Value>& value) |
| { |
| - v8::String::Utf8Value stringValue(value); |
| + v8::String::Utf8Value stringValue(isolate, value); |
| if (stringValue.length()) |
| return std::string(*stringValue, stringValue.length()); |
| else |
| return std::string(); |
| } |
| -StringBuffer Utils::StringBufferFromV8String(const v8::Local<v8::Value>& value) |
| +StringBuffer Utils::StringBufferFromV8String(v8::Isolate* isolate, const v8::Local<v8::Value>& value) |
| { |
| - v8::String::Utf8Value stringValue(value); |
| + v8::String::Utf8Value stringValue(isolate, value); |
| if (stringValue.length()) |
| return IFileSystem::IOBuffer(*stringValue, *stringValue + stringValue.length()); |
| else |
« src/FileSystemJsObject.cpp ('K')
|
« src/Utils.h ('k')
|
no next file »
|
no next file with comments »
