Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29810573: Issue 6526 - Remove deprecated Utf8Value() usage (Closed)

Created:
June 19, 2018, 5:11 p.m. by hub
Modified:
June 20, 2018, 3:04 p.m.
Reviewers:
sergei
Base URL:
https://hg.adblockplus.org/libadblockplus/
Visibility:
Public.

Description

Issue 6526 - Remove deprecated Utf8Value() usage

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -26 lines) Patch
M src/ConsoleJsObject.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/FileSystemJsObject.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/JsEngine.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M src/JsError.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/JsError.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M src/JsValue.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/Utils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/Utils.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3
hub
June 19, 2018, 5:12 p.m. (2018-06-19 17:12:14 UTC) #1
hub
FWIW, In 6.7, the non Maybe<> API for NewFromUtf8 is marked as "soon to be ...
June 20, 2018, 12:47 p.m. (2018-06-20 12:47:31 UTC) #2
hub
June 20, 2018, 3:04 p.m. (2018-06-20 15:04:47 UTC) #3
it was already done, closing.

Powered by Google App Engine
This is Rietveld