Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29812630: Issue 6750 - Update libadblockplus dependency to revision hg:4f6413dbcf2e (Closed)

Created:
June 21, 2018, 6:17 p.m. by anton
Modified:
June 22, 2018, 11:36 a.m.
Visibility:
Public.

Description

Issue 6750 - Update libadblockplus dependency to revision hg:4f6413dbcf2e This is replacement for code review https://codereview.adblockplus.org/29810565/ which is LGTMed and has pretty the same. I've figured out that i've applied it to not the most recent version of libadblockplus so some paths are changed (eg. `libadblockplus-android` renamed to `adblockplus-android`). Also i've renamed the ticket and replaced libadblockplus revisions.

Patch Set 1 #

Patch Set 2 : Updated Android.mk because of different dirs per prebuilt libs. #

Total comments: 1

Patch Set 3 : Updated versions #

Total comments: 8

Patch Set 4 : Updated .gitignore and .hgignore files #

Patch Set 5 : addressed Sergey comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -99 lines) Patch
M .gitignore View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M .hgignore View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M README.md View 1 2 3 4 3 chunks +19 lines, -7 lines 0 comments Download
M adblock-android-settings/build.gradle View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M adblock-android-webview/build.gradle View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M adblock-android-webviewapp/build.gradle View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M adblock-android/build.gradle View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M adblock-android/jni/Android.mk View 1 2 chunks +79 lines, -83 lines 0 comments Download
M dependencies View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
jens
LGTM https://codereview.adblockplus.org/29812630/diff/29812639/dependencies File dependencies (right): https://codereview.adblockplus.org/29812630/diff/29812639/dependencies#newcode4 dependencies:4: libadblockplus = libadblockplus hg:4f6413dbcf2e git:40f5d4d2d00abe3f94ce69210267bcce908cd748 Since I can ...
June 22, 2018, 7:07 a.m. (2018-06-22 07:07:09 UTC) #1
sergei
LGTM https://codereview.adblockplus.org/29812630/diff/29813555/README.md File README.md (right): https://codereview.adblockplus.org/29812630/diff/29813555/README.md#newcode30 README.md:30: First, we need to build `V8` required for ...
June 22, 2018, 9:21 a.m. (2018-06-22 09:21:17 UTC) #2
anton
https://codereview.adblockplus.org/29812630/diff/29813555/README.md File README.md (right): https://codereview.adblockplus.org/29812630/diff/29813555/README.md#newcode30 README.md:30: First, we need to build `V8` required for `libadblockplus`. ...
June 22, 2018, 10:58 a.m. (2018-06-22 10:58:18 UTC) #3
sergei
June 22, 2018, 11:24 a.m. (2018-06-22 11:24:58 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld