Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(31)

Issue 29813591: Issue 6526 - Use Maybe<> version of soon to be deprecated API in v8 6.7

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 5 days ago by hub
Modified:
2 weeks ago
Reviewers:
sergei
Base URL:
https://hg.adblockplus.org/libadblockplus/
Visibility:
Public.

Description

Issue 6526 - Use Maybe<> version of soon to be deprecated API in v8 6.7

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -14 lines) Patch
M src/JsEngine.cpp View 2 chunks +11 lines, -7 lines 0 comments Download
M src/JsValue.cpp View 2 chunks +15 lines, -5 lines 1 comment Download
M src/Utils.h View 2 chunks +17 lines, -1 line 0 comments Download
M test/JsValue.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
hub
3 weeks, 5 days ago (2018-06-22 20:54:43 UTC) #1
hub
This is the last bits. On top of the previous patch https://codereview.adblockplus.org/29812649/ There are 3 ...
3 weeks, 5 days ago (2018-06-22 20:55:48 UTC) #2
hub
3 weeks, 5 days ago (2018-06-22 21:32:39 UTC) #3
https://codereview.adblockplus.org/29813591/diff/29813592/src/JsValue.cpp
File src/JsValue.cpp (right):

https://codereview.adblockplus.org/29813591/diff/29813592/src/JsValue.cpp#new...
src/JsValue.cpp:141: return value.IsJust() ? value.FromJust() : 0;
The test expect that if accessing value throw a JS exception, it returns 0,
which is the previous behaviour. With this API I get an empty Maybe<> when the
exception is thrown (see test/JsValue.cpp), so I make it return 0.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5