Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(582)

Issue 29825642: Noissue - add 7z requirement into README.md (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by sergei
Modified:
1 month ago
Reviewers:
hub
CC:
anton
Base URL:
https://github.com/adblockplus/libadblockplus@d361cdf75c6c5af2aaa9b484092ded6c0a1dc441
Visibility:
Public.

Description

Since we document how to obtain prebuilt V8 binaries for *nix we should mention also tools required for that. Additionally it can help to find out all missing requirements in the derived projects.

Patch Set 1 #

Total comments: 3

Patch Set 2 : address comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M README.md View 1 1 chunk +6 lines, -1 line 2 comments Download

Messages

Total messages: 7
sergei
https://codereview.adblockplus.org/29825642/diff/29825647/README.md File README.md (right): https://codereview.adblockplus.org/29825642/diff/29825647/README.md#newcode32 README.md:32: one can use `p7zip-full` package and `p7zip` on rpm ...
2 months, 1 week ago (2018-07-09 14:11:17 UTC) #1
hub
https://codereview.adblockplus.org/29825642/diff/29825647/README.md File README.md (right): https://codereview.adblockplus.org/29825642/diff/29825647/README.md#newcode32 README.md:32: one can use `p7zip-full` package and `p7zip` on rpm ...
2 months, 1 week ago (2018-07-09 14:44:39 UTC) #2
sergei
https://codereview.adblockplus.org/29825642/diff/29825647/README.md File README.md (right): https://codereview.adblockplus.org/29825642/diff/29825647/README.md#newcode32 README.md:32: one can use `p7zip-full` package and `p7zip` on rpm ...
2 months, 1 week ago (2018-07-09 15:20:32 UTC) #3
hub
https://codereview.adblockplus.org/29825642/diff/29825659/README.md File README.md (right): https://codereview.adblockplus.org/29825642/diff/29825659/README.md#newcode32 README.md:32: one can use `p7zip-full` package and `p7zip-plugins` on rpm-based. ...
2 months, 1 week ago (2018-07-13 14:39:36 UTC) #4
hub
otherwise LGTM.
2 months, 1 week ago (2018-07-13 16:11:28 UTC) #5
hub
this one should be checked in
1 month ago (2018-08-16 18:18:15 UTC) #6
sergei
1 month ago (2018-08-20 10:07:34 UTC) #7
Since I made a change, I have moved it to gitlab,
https://gitlab.com/eyeo/adblockplus/libadblockplus/merge_requests/12. Let's
continue there.

https://codereview.adblockplus.org/29825642/diff/29825659/README.md
File README.md (right):

https://codereview.adblockplus.org/29825642/diff/29825659/README.md#newcode32
README.md:32: one can use `p7zip-full` package and `p7zip-plugins` on rpm-based.
On 2018/07/13 14:39:36, hub wrote:
> I'd write 
> 
> "one can use `p7zip-full` package, or `p7zip-plugins` on rpm-based"
> 
> BTW I'm unsure about "RPM based" since I don't know what SuSE does use for
their
> package name. It possibly differ from Fedora based (or RHEL)

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5