Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(42)

Issue 29825642: Noissue - add 7z requirement into README.md

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 2 days ago by sergei
Modified:
5 days, 17 hours ago
Reviewers:
hub
CC:
anton
Base URL:
https://github.com/adblockplus/libadblockplus@d361cdf75c6c5af2aaa9b484092ded6c0a1dc441
Visibility:
Public.

Description

Since we document how to obtain prebuilt V8 binaries for *nix we should mention also tools required for that. Additionally it can help to find out all missing requirements in the derived projects.

Patch Set 1 #

Total comments: 3

Patch Set 2 : address comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M README.md View 1 1 chunk +6 lines, -1 line 1 comment Download

Messages

Total messages: 5
sergei
https://codereview.adblockplus.org/29825642/diff/29825647/README.md File README.md (right): https://codereview.adblockplus.org/29825642/diff/29825647/README.md#newcode32 README.md:32: one can use `p7zip-full` package and `p7zip` on rpm ...
1 week, 2 days ago (2018-07-09 14:11:17 UTC) #1
hub
https://codereview.adblockplus.org/29825642/diff/29825647/README.md File README.md (right): https://codereview.adblockplus.org/29825642/diff/29825647/README.md#newcode32 README.md:32: one can use `p7zip-full` package and `p7zip` on rpm ...
1 week, 2 days ago (2018-07-09 14:44:39 UTC) #2
sergei
https://codereview.adblockplus.org/29825642/diff/29825647/README.md File README.md (right): https://codereview.adblockplus.org/29825642/diff/29825647/README.md#newcode32 README.md:32: one can use `p7zip-full` package and `p7zip` on rpm ...
1 week, 2 days ago (2018-07-09 15:20:32 UTC) #3
hub
https://codereview.adblockplus.org/29825642/diff/29825659/README.md File README.md (right): https://codereview.adblockplus.org/29825642/diff/29825659/README.md#newcode32 README.md:32: one can use `p7zip-full` package and `p7zip-plugins` on rpm-based. ...
5 days, 18 hours ago (2018-07-13 14:39:36 UTC) #4
hub
5 days, 17 hours ago (2018-07-13 16:11:28 UTC) #5
otherwise LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5