Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29870565: Issue 6915 - Add developers to contributors page (Closed)

Created:
Aug. 31, 2018, 10:36 p.m. by Manish Jethani
Modified:
Sept. 4, 2018, 1:15 p.m.
Base URL:
https://hg.adblockplus.org/web.adblockplus.org/
Visibility:
Public.

Description

I have added the names of developers that were missing from the list. The names are based on the commit logs of adblockpluschrome and its dependencies (buildtools, adblockpluscore, and adblockplusui) for the last one year. The order in which the names appear is roughly based on the order in which the developers joined the Adblock Plus project; when in doubt, I went by the developer's level of involvement in the project, based on my limited knowledge and the number of commits in the logs. I can't get this one hundred percent right of course, feel free to make suggestions. I have left out the names of external contributors with one or two minor commits, since they would hardly qualify as "team" (but may be added later in a different section separately).

Patch Set 1 #

Total comments: 1

Patch Set 2 : Move new historical contributors to bottom #

Total comments: 12

Patch Set 3 : Address comments to Patch Set 2 #

Total comments: 4

Patch Set 4 : Address comments to Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -21 lines) Patch
M pages/contributors.html View 1 2 3 3 chunks +53 lines, -21 lines 0 comments Download

Messages

Total messages: 10
Manish Jethani
Aug. 31, 2018, 10:36 p.m. (2018-08-31 22:36:25 UTC) #1
Manish Jethani
Patch Set 1 This change is only about adding developers' names based on the commit ...
Aug. 31, 2018, 10:49 p.m. (2018-08-31 22:49:53 UTC) #2
Manish Jethani
Patch Set 2: Move new historical contributors to bottom
Aug. 31, 2018, 10:59 p.m. (2018-08-31 22:59:56 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29870565/diff/29870568/pages/contributors.html File pages/contributors.html (right): https://codereview.adblockplus.org/29870565/diff/29870568/pages/contributors.html#newcode112 pages/contributors.html:112: <td>{{s4 Founder & Lead Developer}}</td> At least Wladimir is ...
Aug. 31, 2018, 11:31 p.m. (2018-08-31 23:31:28 UTC) #4
Manish Jethani
Patch Set 3 https://codereview.adblockplus.org/29870565/diff/29870568/pages/contributors.html File pages/contributors.html (right): https://codereview.adblockplus.org/29870565/diff/29870568/pages/contributors.html#newcode112 pages/contributors.html:112: <td>{{s4 Founder & Lead Developer}}</td> On ...
Sept. 1, 2018, 12:29 a.m. (2018-09-01 00:29:05 UTC) #5
Sebastian Noack
https://codereview.adblockplus.org/29870565/diff/29870568/pages/contributors.html File pages/contributors.html (right): https://codereview.adblockplus.org/29870565/diff/29870568/pages/contributors.html#newcode144 pages/contributors.html:144: <td>{{s6 Developer}}</td> On 2018/09/01 00:29:04, Manish Jethani wrote: > ...
Sept. 1, 2018, 12:34 a.m. (2018-09-01 00:34:12 UTC) #6
Manish Jethani
Patch Set 4 https://codereview.adblockplus.org/29870565/diff/29870568/pages/contributors.html File pages/contributors.html (right): https://codereview.adblockplus.org/29870565/diff/29870568/pages/contributors.html#newcode144 pages/contributors.html:144: <td>{{s6 Developer}}</td> On 2018/09/01 00:34:12, Sebastian ...
Sept. 1, 2018, 12:39 a.m. (2018-09-01 00:39:39 UTC) #7
Sebastian Noack
LGTM https://codereview.adblockplus.org/29870565/diff/29870570/pages/contributors.html File pages/contributors.html (right): https://codereview.adblockplus.org/29870565/diff/29870570/pages/contributors.html#newcode111 pages/contributors.html:111: <td>Sebastian Noack</td> On 2018/09/01 00:39:39, Manish Jethani wrote: ...
Sept. 1, 2018, 1:49 a.m. (2018-09-01 01:49:19 UTC) #8
Manish Jethani
On 2018/09/01 01:49:19, Sebastian Noack wrote: > LGTM Thanks! Julian, what do you think? https://codereview.adblockplus.org/29870565/diff/29870570/pages/contributors.html ...
Sept. 1, 2018, 2:31 a.m. (2018-09-01 02:31:41 UTC) #9
juliandoucette
Sept. 4, 2018, 12:43 p.m. (2018-09-04 12:43:59 UTC) #10
LGTM

Powered by Google App Engine
This is Rietveld