Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29892593: Noissue - Avoid string replacement for domains with no trailing dots (Closed)

Created:
Sept. 26, 2018, 10:55 p.m. by Manish Jethani
Modified:
Sept. 27, 2018, 7:48 p.m.
Reviewers:
hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M lib/filterClasses.js View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Manish Jethani
Sept. 26, 2018, 10:55 p.m. (2018-09-26 22:55:08 UTC) #1
Manish Jethani
Patch Set 1 Try this: (function() { let array = []; for (let i = ...
Sept. 26, 2018, 10:58 p.m. (2018-09-26 22:58:15 UTC) #2
hub
Sept. 27, 2018, 6:50 p.m. (2018-09-27 18:50:56 UTC) #3
nice catch

LGTM

Powered by Google App Engine
This is Rietveld