Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(418)

Issue 29897555: Issue 6940 - Replace keywordByFilter with _keywordByFilter in lib/matcher.js

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 4 days ago by Jon Sonesen
Modified:
2 weeks, 2 days ago
Reviewers:
Manish Jethani
Visibility:
Public.

Description

Issue 6940 - Replace keywordByFilter with _keywordByFilter in lib/matcher.js

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M lib/matcher.js View 3 chunks +8 lines, -8 lines 2 comments Download

Messages

Total messages: 7
Jon Sonesen
2 weeks, 4 days ago (2018-10-01 05:46:11 UTC) #1
Jon Sonesen
Pretty sure the commit message could be changed, since it seems this issue may include ...
2 weeks, 4 days ago (2018-10-01 05:46:54 UTC) #2
Manish Jethani
I think it would be more practical to base this on https://codereview.adblockplus.org/29892596/ What do you ...
2 weeks, 4 days ago (2018-10-01 10:25:56 UTC) #3
Jon Sonesen
On 2018/10/01 10:25:56, Manish Jethani wrote: > I think it would be more practical to ...
2 weeks, 4 days ago (2018-10-01 15:02:58 UTC) #4
Manish Jethani
https://codereview.adblockplus.org/29897555/diff/29897556/lib/matcher.js File lib/matcher.js (right): https://codereview.adblockplus.org/29897555/diff/29897556/lib/matcher.js#newcode44 lib/matcher.js:44: this._keywordByFilter = new Map(); I think we should add ...
2 weeks, 4 days ago (2018-10-01 15:08:59 UTC) #5
Manish Jethani
https://codereview.adblockplus.org/29897555/diff/29897556/lib/matcher.js File lib/matcher.js (right): https://codereview.adblockplus.org/29897555/diff/29897556/lib/matcher.js#newcode44 lib/matcher.js:44: this._keywordByFilter = new Map(); On 2018/10/01 15:08:59, Manish Jethani ...
2 weeks, 4 days ago (2018-10-01 15:10:00 UTC) #6
Manish Jethani
2 weeks, 3 days ago (2018-10-02 17:26:30 UTC) #7
You could rebase this one now.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5