Unified Diff: packager.py
Issue 29983597:
Noissue - Fixed: extension_id_* option was ignored in builds for MS Edge (Closed)
Patch Set:
Created Jan. 17, 2019, 1:19 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
packagerEdge.py » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: packager.py |
| =================================================================== |
| --- a/packager.py |
| +++ b/packager.py |
| @@ -42,12 +42,13 @@ |
| return extension |
| -def get_app_id(release_build, metadata): |
| - """Lookup the correct app_id for a build.""" |
| +def get_build_specific_option(release_build, metadata, prefix): |
| suffix = 'release' if release_build else 'devbuild' |
| - app_id_option = 'app_id_' + suffix |
| + return metadata.get('general', '{}_{}'.format(prefix, suffix)) |
| + |
| - return metadata.get('general', app_id_option) |
| +def get_app_id(release_build, metadata): |
| + return get_build_specific_option(release_build, metadata, 'app_id') |
| def getMetadataPath(baseDir, type): |
« no previous file with comments
|
« no previous file
|
packagerEdge.py » ('j')
|
no next file with comments »
