Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: packagerEdge.py

Issue 29983597: Noissue - Fixed: extension_id_* option was ignored in builds for MS Edge (Closed)
Patch Set: Created Jan. 17, 2019, 1:19 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packager.py ('k') | tests/expecteddata/AppxManifest_edge_release_build.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packagerEdge.py
===================================================================
--- a/packagerEdge.py
+++ b/packagerEdge.py
@@ -12,6 +12,7 @@
import tempfile
from xml.etree import ElementTree
from zipfile import ZipFile
+import ConfigParser
import packager
import packagerChrome
@@ -70,7 +71,6 @@
filenames.append(icon_path)
assets = packagerChrome.makeIcons(files, filenames)
-
author = metadata.get('general', 'author')
overrides = [
@@ -91,6 +91,18 @@
]),
]
+ try:
+ overrides.append((
+ '_d:Applications/_d:Application/_d:Extensions/' +
+ 'uap3:Extension/uap3:AppExtension',
+ None,
+ [('Id', packager.get_build_specific_option(release_build,
+ metadata,
+ 'extension_id'))],
+ ))
+ except ConfigParser.NoOptionError:
+ pass
+
tree = ElementTree.parse(manifest_path)
root = tree.getroot()
« no previous file with comments | « packager.py ('k') | tests/expecteddata/AppxManifest_edge_release_build.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld