Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4797021667983360: [IE] remove <atlhost.h> (Closed)

Created:
July 20, 2014, 7:01 p.m. by Eric
Modified:
July 22, 2014, 2:15 p.m.
Visibility:
Public.

Description

Remove <atlhost.h>, replacing it with another include and an explicitly linked library.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M adblockplus.gyp View 1 chunk +1 line, -0 lines 2 comments Download
M src/plugin/PluginStdAfx.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/plugin/PluginTabBase.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
Eric
July 20, 2014, 7:04 p.m. (2014-07-20 19:04:59 UTC) #1
Oleksandr
LGTM!
July 21, 2014, 9:10 a.m. (2014-07-21 09:10:04 UTC) #2
Felix Dahlke
Just a nit :) http://codereview.adblockplus.org/4797021667983360/diff/5629499534213120/adblockplus.gyp File adblockplus.gyp (right): http://codereview.adblockplus.org/4797021667983360/diff/5629499534213120/adblockplus.gyp#newcode117 adblockplus.gyp:117: '-lGdi32', Indentation is off here
July 21, 2014, 9:38 a.m. (2014-07-21 09:38:22 UTC) #3
sergei
The description should be "Issue 123 - Should do foo, not bar... Cannot apply the ...
July 21, 2014, 9:51 a.m. (2014-07-21 09:51:10 UTC) #4
Eric
July 22, 2014, 2:15 p.m. (2014-07-22 14:15:31 UTC) #5
http://codereview.adblockplus.org/4797021667983360/diff/5629499534213120/adbl...
File adblockplus.gyp (right):

http://codereview.adblockplus.org/4797021667983360/diff/5629499534213120/adbl...
adblockplus.gyp:117: '-lGdi32',
On 2014/07/21 09:38:22, Felix H. Dahlke wrote:
> Indentation is off here
I've been burned by indentation in Visual Studio before. I thought I took care
of it already, but apparently not in this case.

In any case, fixed.

Powered by Google App Engine
This is Rietveld