Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(121)

Issue 4842319220047872: Fix mime type detection (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by Oleksandr
Modified:
5 years, 8 months ago
Reviewers:
Eric, Wladimir Palant
Visibility:
Public.

Description

Fix mime type detection

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/plugin/PluginWbPassThrough.cpp View 1 chunk +3 lines, -3 lines 2 comments Download

Messages

Total messages: 2
Oleksandr
http://codereview.adblockplus.org/4842319220047872/diff/5629499534213120/src/plugin/PluginWbPassThrough.cpp File src/plugin/PluginWbPassThrough.cpp (right): http://codereview.adblockplus.org/4842319220047872/diff/5629499534213120/src/plugin/PluginWbPassThrough.cpp#newcode140 src/plugin/PluginWbPassThrough.cpp:140: pOIBindInfo->GetBindString(BINDSTRING_ACCEPT_MIMES, mime, 10, &resLen); Apparently IE will report random ...
5 years, 10 months ago (2014-04-29 08:56:51 UTC) #1
Eric
5 years, 10 months ago (2014-05-01 15:04:53 UTC) #2
LGTM, assuming a comment added.

http://codereview.adblockplus.org/4842319220047872/diff/5629499534213120/src/...
File src/plugin/PluginWbPassThrough.cpp (right):

http://codereview.adblockplus.org/4842319220047872/diff/5629499534213120/src/...
src/plugin/PluginWbPassThrough.cpp:140:
pOIBindInfo->GetBindString(BINDSTRING_ACCEPT_MIMES, mime, 10, &resLen);
On 2014/04/29 08:56:51, Oleksandr wrote:
> Apparently IE will report random mime type if there's more then 1 in the list.
> So we get the whole list and just use the first one (top priority one)
This behavior belongs in a comment, since it's certainly not in Microsoft's
documentation. It'll be effectively lost if it's only in review comments.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5