Issue 4842319220047872: Fix mime type detection

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4842319220047872: Fix mime type detection (Closed)

Created:
April 29, 2014, 8:43 a.m. by Oleksandr

Modified:
June 26, 2014, 12:51 a.m.

Reviewers:
Eric, Wladimir Palant

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: April 29, 2014, 8:43 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/plugin/PluginWbPassThrough.cpp	View		1 chunk	+3 lines, -3 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Oleksandr

http://codereview.adblockplus.org/4842319220047872/diff/5629499534213120/src/plugin/PluginWbPassThrough.cpp File src/plugin/PluginWbPassThrough.cpp (right): http://codereview.adblockplus.org/4842319220047872/diff/5629499534213120/src/plugin/PluginWbPassThrough.cpp#newcode140 src/plugin/PluginWbPassThrough.cpp:140: pOIBindInfo->GetBindString(BINDSTRING_ACCEPT_MIMES, mime, 10, &resLen); Apparently IE will report random ...

April 29, 2014, 8:56 a.m. (2014-04-29 08:56:51 UTC) #1

Eric

May 1, 2014, 3:04 p.m. (2014-05-01 15:04:53 UTC) #2

LGTM, assuming a comment added.

http://codereview.adblockplus.org/4842319220047872/diff/5629499534213120/src/...
File src/plugin/PluginWbPassThrough.cpp (right):

http://codereview.adblockplus.org/4842319220047872/diff/5629499534213120/src/...
src/plugin/PluginWbPassThrough.cpp:140:
pOIBindInfo->GetBindString(BINDSTRING_ACCEPT_MIMES, mime, 10, &resLen);
On 2014/04/29 08:56:51, Oleksandr wrote:
> Apparently IE will report random mime type if there's more then 1 in the list.
> So we get the whole list and just use the first one (top priority one)
This behavior belongs in a comment, since it's certainly not in Microsoft's
documentation. It'll be effectively lost if it's only in review comments.

Expand All Messages | Collapse All Messages