Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(201)

Issue 4859386648330240: Fix named pipe security on Windows XP (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 2 months ago by Oleksandr
Modified:
5 years, 1 month ago
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Fix named pipe security on Windows XP

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M src/plugin/AdblockPlusClient.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/shared/Communication.cpp View 1 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 4
Oleksandr
5 years, 2 months ago (2014-06-16 10:30:21 UTC) #1
Felix Dahlke
http://codereview.adblockplus.org/4859386648330240/diff/5629499534213120/src/plugin/AdblockPlusClient.cpp File src/plugin/AdblockPlusClient.cpp (right): http://codereview.adblockplus.org/4859386648330240/diff/5629499534213120/src/plugin/AdblockPlusClient.cpp#newcode45 src/plugin/AdblockPlusClient.cpp:45: if ((acs != NULL && acs->TokenAppContainer != NULL) || ...
5 years, 2 months ago (2014-06-24 12:25:05 UTC) #2
Oleksandr
Comments addressed in patch set #2
5 years, 1 month ago (2014-06-26 00:59:30 UTC) #3
Felix Dahlke
5 years, 1 month ago (2014-06-27 14:32:28 UTC) #4
LGTM!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5