Issue 4859386648330240: Fix named pipe security on Windows XP

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4859386648330240: Fix named pipe security on Windows XP (Closed)

Created:
June 16, 2014, 10:15 a.m. by Oleksandr

Modified:
July 2, 2014, 9:21 a.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Patch Set 2 : #

Created: June 26, 2014, 12:57 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -9 lines)			Patch
	M	src/plugin/AdblockPlusClient.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/shared/Communication.cpp	View	1	1 chunk	+2 lines, -8 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Felix Dahlke

http://codereview.adblockplus.org/4859386648330240/diff/5629499534213120/src/plugin/AdblockPlusClient.cpp File src/plugin/AdblockPlusClient.cpp (right): http://codereview.adblockplus.org/4859386648330240/diff/5629499534213120/src/plugin/AdblockPlusClient.cpp#newcode45 src/plugin/AdblockPlusClient.cpp:45: if ((acs != NULL && acs->TokenAppContainer != NULL) || ...

June 24, 2014, 12:25 p.m. (2014-06-24 12:25:05 UTC) #2

LGTM!

Expand All Messages | Collapse All Messages