Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 4875452820750336: Issue 1663 - Moving first-run page to adblockplusui repository (Closed)

Created:
Dec. 16, 2014, 1:59 p.m. by Wladimir Palant
Modified:
Dec. 17, 2014, 10:01 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

This is the initial commit for the adblockplusui repository, mostly a FYI review - nothing changed here, merely the locales have been converted to JSON format which is easier to deal with than properties files.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4812 lines, -0 lines) Patch
A firstRun.html View 1 chunk +145 lines, -0 lines 0 comments Download
A firstRun.js View 1 chunk +250 lines, -0 lines 0 comments Download
A i18n.js View 1 chunk +154 lines, -0 lines 0 comments Download
A locale/ar/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/ast/firstRun.json View 1 chunk +20 lines, -0 lines 0 comments Download
A locale/bg/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/bn-BD/firstRun.json View 1 chunk +17 lines, -0 lines 0 comments Download
A locale/bs/firstRun.json View 1 chunk +53 lines, -0 lines 0 comments Download
A locale/ca/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/cs/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/cy/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/da/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/de/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/dsb/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/el/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/en-GB/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/en-US/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/eo/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/es-AR/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/es-CL/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/es-ES/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/es-MX/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/et/firstRun.json View 1 chunk +50 lines, -0 lines 0 comments Download
A locale/eu/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/fa/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/fi/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/fr/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/fy-NL/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/gl/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/he/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/hi-IN/firstRun.json View 1 chunk +14 lines, -0 lines 0 comments Download
A locale/hr/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/hsb/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/hu/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/hy-AM/firstRun.json View 1 chunk +59 lines, -0 lines 0 comments Download
A locale/id/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/is/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/it/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/ja/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/kk/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/ko/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/lt/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/lv/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/mk/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/mr/firstRun.json View 1 chunk +59 lines, -0 lines 0 comments Download
A locale/ms/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/nb-NO/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/nl/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/pl/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/pt-BR/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/pt-PT/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/ro/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/ru/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/sk/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/sl/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/sq/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/sr/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/sv-SE/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/ta-LK/firstRun.json View 1 chunk +44 lines, -0 lines 0 comments Download
A locale/th/firstRun.json View 1 chunk +47 lines, -0 lines 0 comments Download
A locale/tr/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/uk/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/vi/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/zh-CN/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A locale/zh-TW/firstRun.json View 1 chunk +62 lines, -0 lines 0 comments Download
A skin/abp-icon-big.png View Binary file 0 comments Download
A skin/ajax-loader.gif View Binary file 0 comments Download
A skin/background.png View Binary file 0 comments Download
A skin/background-main.png View Binary file 0 comments Download
A skin/background-share.png View Binary file 0 comments Download
A skin/donate.png View Binary file 0 comments Download
A skin/features/malware.png View Binary file 0 comments Download
A skin/features/social.png View Binary file 0 comments Download
A skin/features/tracking.png View Binary file 0 comments Download
A skin/firstRun.css View 1 chunk +590 lines, -0 lines 0 comments Download
A skin/fonts/CreteRound-Italic.otf View Binary file 0 comments Download
A skin/fonts/CreteRound-Regular.otf View Binary file 0 comments Download
A skin/social/facebook.png View Binary file 0 comments Download
A skin/social/googleplus.png View Binary file 0 comments Download
A skin/social/renren.png View Binary file 0 comments Download
A skin/social/twitter.png View Binary file 0 comments Download
A skin/social/weibo.png View Binary file 0 comments Download
A utils.js View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Wladimir Palant
Dec. 16, 2014, 2 p.m. (2014-12-16 14:00:06 UTC) #1
Thomas Greiner
Dec. 17, 2014, 10:18 a.m. (2014-12-17 10:18:09 UTC) #2 
LGTM

FYI: I looked at whether all necessary files are in there and whether the
converted locale files are ok since you said that you didn't touch any of the
other code.

Powered by Google App Engine
This is Rietveld