Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4895405913407488: Issue #1234 - remove CString from declarations representing domains. (Closed)

Created:
Aug. 7, 2014, 7:46 p.m. by Eric
Modified:
Oct. 2, 2014, 8:25 p.m.
Reviewers:
Felix Dahlke, Oleksandr
CC:
sergei
Visibility:
Public.

Description

Issue #1234 - remove CString from declarations representing domains. Replaced CString with std::wstring in a number of declarations that represent domains. CPluginDebug::DebugResultBlocking, argument CPluginDebug::DebugResultIgnoring, argument CPluginDomTraverserBase::TraverseDocument, argument, argument CPluginDomTraverserBase::TraverseSubdocument, argument CPluginDomTraverserBase::m_domain CPluginTabBase::m_documentDomain CPluginTabBase::m_cacheDomain CPluginTabBase::GetDocumentDomain, return value CPluginTabBase::ClearFrameCache, return value WBPassthruSink::GetContentType, argument Changed function bodies only as expedient; some occurrence of CString remain. Removed dead function IsValidDomain().

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -51 lines) Patch
M src/plugin/AdblockPlusDomTraverser.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/plugin/PluginClientBase.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/plugin/PluginClientBase.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M src/plugin/PluginDebug.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/plugin/PluginDebug.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/plugin/PluginDomTraverserBase.h View 5 chunks +6 lines, -6 lines 0 comments Download
M src/plugin/PluginFilter.cpp View 3 chunks +2 lines, -5 lines 0 comments Download
M src/plugin/PluginTabBase.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/plugin/PluginTabBase.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M src/plugin/PluginWbPassThrough.h View 1 chunk +1 line, -1 line 0 comments Download
M src/plugin/PluginWbPassThrough.cpp View 6 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 3
Eric
Aug. 7, 2014, 7:50 p.m. (2014-08-07 19:50:22 UTC) #1
Oleksandr
LGTM
Aug. 21, 2014, 4:24 p.m. (2014-08-21 16:24:13 UTC) #2
Felix Dahlke
Sept. 30, 2014, 1:25 p.m. (2014-09-30 13:25:46 UTC) #3
Nice, LGTM.

Powered by Google App Engine
This is Rietveld