Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(40)

Issue 4920381332783104: Issue 1339 - Page automatically reloads when ABP enabled or disabled by user (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by Oleksandr
Modified:
4 years, 8 months ago
Reviewers:
Eric, sergei
CC:
Felix Dahlke
Visibility:
Public.

Description

Just don't reload the page when user enables/disables ABP on site.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/plugin/PluginClass.cpp View 1 chunk +0 lines, -1 line 2 comments Download

Messages

Total messages: 5
Oleksandr
4 years, 10 months ago (2015-03-27 08:15:39 UTC) #1
Eric
http://codereview.adblockplus.org/4920381332783104/diff/5629499534213120/src/plugin/PluginClass.cpp File src/plugin/PluginClass.cpp (left): http://codereview.adblockplus.org/4920381332783104/diff/5629499534213120/src/plugin/PluginClass.cpp#oldcode1163 src/plugin/PluginClass.cpp:1163: GetBrowser()->Refresh(); When a user disables ABP, blocked items (if ...
4 years, 10 months ago (2015-03-27 13:56:23 UTC) #2
Oleksandr
http://codereview.adblockplus.org/4920381332783104/diff/5629499534213120/src/plugin/PluginClass.cpp File src/plugin/PluginClass.cpp (left): http://codereview.adblockplus.org/4920381332783104/diff/5629499534213120/src/plugin/PluginClass.cpp#oldcode1163 src/plugin/PluginClass.cpp:1163: GetBrowser()->Refresh(); On 2015/03/27 13:56:23, Eric wrote: > When a ...
4 years, 10 months ago (2015-03-27 14:53:58 UTC) #3
sergei
LGTM
4 years, 10 months ago (2015-03-30 07:28:49 UTC) #4
Eric
4 years, 9 months ago (2015-05-13 12:08:15 UTC) #5
LGTM.

For the record, I'll reiterate that I think the behavior of having an icon that
shows "enabled" when the web page is showing "not enabled" is a bad user
experience. But since we appear to be valuing consistency of this behavior with
other platforms over inconsistency within this platform, this code accomplishes
that.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5