Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4920381332783104: Issue 1339 - Page automatically reloads when ABP enabled or disabled by user (Closed)

Created:
March 27, 2015, 8:11 a.m. by Oleksandr
Modified:
June 1, 2015, 9:26 a.m.
Reviewers:
sergei, Eric
CC:
Felix Dahlke
Visibility:
Public.

Description

Just don't reload the page when user enables/disables ABP on site.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/plugin/PluginClass.cpp View 1 chunk +0 lines, -1 line 2 comments Download

Messages

Total messages: 5
Oleksandr
March 27, 2015, 8:15 a.m. (2015-03-27 08:15:39 UTC) #1
Eric
http://codereview.adblockplus.org/4920381332783104/diff/5629499534213120/src/plugin/PluginClass.cpp File src/plugin/PluginClass.cpp (left): http://codereview.adblockplus.org/4920381332783104/diff/5629499534213120/src/plugin/PluginClass.cpp#oldcode1163 src/plugin/PluginClass.cpp:1163: GetBrowser()->Refresh(); When a user disables ABP, blocked items (if ...
March 27, 2015, 1:56 p.m. (2015-03-27 13:56:23 UTC) #2
Oleksandr
http://codereview.adblockplus.org/4920381332783104/diff/5629499534213120/src/plugin/PluginClass.cpp File src/plugin/PluginClass.cpp (left): http://codereview.adblockplus.org/4920381332783104/diff/5629499534213120/src/plugin/PluginClass.cpp#oldcode1163 src/plugin/PluginClass.cpp:1163: GetBrowser()->Refresh(); On 2015/03/27 13:56:23, Eric wrote: > When a ...
March 27, 2015, 2:53 p.m. (2015-03-27 14:53:58 UTC) #3
sergei
LGTM
March 30, 2015, 7:28 a.m. (2015-03-30 07:28:49 UTC) #4
Eric
May 13, 2015, 12:08 p.m. (2015-05-13 12:08:15 UTC) #5
LGTM.

For the record, I'll reiterate that I think the behavior of having an icon that
shows "enabled" when the web page is showing "not enabled" is a bad user
experience. But since we appear to be valuing consistency of this behavior with
other platforms over inconsistency within this platform, this code accomplishes
that.

Powered by Google App Engine
This is Rietveld