Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4923675673362432: Noissue - Change build order for the include and library directories of ATL. (Closed)

Created:
May 21, 2015, 9:25 p.m. by Eric
Modified:
Dec. 3, 2015, 7:45 p.m.
Reviewers:
sergei, Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Description

Noissue - Change build order for the include and library directories of ATL. The ATL directories for Pro editions of Visual Studio appear before those for WinDDK, which is our designated build environment. Change the order to place the WinDDK directories first. ----- I've tested this only to the extent that it doesn't cause any build error in my environment. This is hardly surprising, since this changes the order of a directory that doesn't exist on my system. The upshot is that I need others to test this that have both Pro and Express installed, to see if this causes the canonical version of ATL to be used.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M adblockplus.gyp View 4 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 1
Eric
May 21, 2015, 10:09 p.m. (2015-05-21 22:09:57 UTC) #1

          

Powered by Google App Engine
This is Rietveld