Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5113321128722432: Noissue - Remove dead headers (Closed)

Created:
Feb. 14, 2015, 6:41 p.m. by Eric
Modified:
Feb. 17, 2015, 1:41 p.m.
Reviewers:
sergei, Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Description

Noissue - Remove dead headers Remove PluginTypedef.h, which had no code at all. Remove AdblockPlusTab.{h,cpp}, which only declared/defined a trival subclass of PluginTabBase. Moved the definition into PluginTabBase.h. Remove PluginTab.h, which only included other headers. Change all the inclusions of PluginTab.h to PluginTabBase.h, which now has exactly the same effect.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -136 lines) Patch
M adblockplus.gyp View 3 chunks +0 lines, -5 lines 0 comments Download
M src/plugin/AdblockPlusClient.h View 1 chunk +0 lines, -1 line 0 comments Download
R src/plugin/AdblockPlusTab.h View 1 chunk +0 lines, -34 lines 0 comments Download
R src/plugin/AdblockPlusTab.cpp View 1 chunk +0 lines, -34 lines 0 comments Download
M src/plugin/PluginClass.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/plugin/PluginClientBase.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/plugin/PluginDomTraverserBase.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/plugin/PluginFilter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/plugin/PluginSettings.h View 1 chunk +0 lines, -1 line 0 comments Download
R src/plugin/PluginTab.h View 1 chunk +0 lines, -24 lines 0 comments Download
M src/plugin/PluginTabBase.h View 1 chunk +14 lines, -0 lines 0 comments Download
M src/plugin/PluginTabBase.cpp View 1 chunk +0 lines, -1 line 0 comments Download
R src/plugin/PluginTypedef.h View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 3
Eric
This is the first part of a refactoring to clean up definition of CPluginTab. It's ...
Feb. 14, 2015, 6:53 p.m. (2015-02-14 18:53:09 UTC) #1
sergei
LGTM
Feb. 14, 2015, 11:14 p.m. (2015-02-14 23:14:27 UTC) #2
Oleksandr
Feb. 17, 2015, 12:22 p.m. (2015-02-17 12:22:04 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld