Issue 5117917230268416: No issue - remove dead code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5117917230268416: No issue - remove dead code (Closed)

Created:
Oct. 8, 2014, 2:46 p.m. by sergei

Modified:
Oct. 13, 2014, 9:27 a.m.

Reviewers:
Eric, Felix Dahlke, Oleksandr

Visibility:
Public.

Description

- get rid of file src/plugin/PluginDomTraverser.h because it's pointless - remove free function `CreateLowProcess` from src\plugin\PluginClass.cpp. It's not used and obsolete. - get rid of CPluginDomTraverserCacheBase::ShowNotification method, it's not used and the body is pointless

Patch Set 1 #

Created: Oct. 8, 2014, 2:46 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -130 lines)			Patch
M	adblockplus.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/plugin/PluginClass.cpp	View	1 chunk	+0 lines, -110 lines	0 comments	Download
R	src/plugin/PluginDomTraverser.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/plugin/PluginDomTraverserBase.h	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	src/plugin/PluginTabBase.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Eric

LGTM. I would recommend, however, adding some descriptive text to the commit message.

Oct. 8, 2014, 5:05 p.m. (2014-10-08 17:05:03 UTC) #2

LGTM

Expand All Messages | Collapse All Messages