Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5145227803230208: Issue 1197 - adapt gyp variables (Closed)

Created:
June 11, 2015, 12:48 p.m. by sergei
Modified:
July 5, 2017, 10:54 a.m.
CC:
Felix Dahlke
Visibility:
Public.

Description

Define v8_use_external_startup_data gyp variable, without it libadblockplus\third_party\v8\tools\gyp\v8.gyp (from v8 4.3.15) fails to generate project files. For additional details see v8 commit 68870ab6ee57a92d140dd2c26b0639fbe84975a6. In particular, in that commit v8_use_external_startup_data has been moved to standalone.gypi. We don't use standalone.gypi so we have to manually define it now. As well as using that commit one can find the background of the change using bug ID (https://code.google.com/p/chromium/issues/detail?id=421063) and review URL.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M common.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9
sergei
June 11, 2015, 1:24 p.m. (2015-06-11 13:24:54 UTC) #1
sergei
Update reviewers.
Jan. 25, 2016, 3:36 p.m. (2016-01-25 15:36:43 UTC) #2
Oleksandr
Just in case here is some more context for the v8 change: https://code.google.com/p/chromium/issues/detail?id=421063 LGTM
Jan. 26, 2016, 5:30 a.m. (2016-01-26 05:30:20 UTC) #3
Eric
Commit message needs better documentation about what this change is doing. Pointing to a particular ...
Jan. 26, 2016, 6:10 p.m. (2016-01-26 18:10:43 UTC) #4
sergei
On 2016/01/26 18:10:43, Eric wrote: > Commit message needs better documentation about what this change ...
Jan. 27, 2016, 9:23 a.m. (2016-01-27 09:23:15 UTC) #5
Eric
On 2016/01/27 09:23:15, sergei wrote: > I have updated the description. The description is adequate ...
Jan. 27, 2016, 3:15 p.m. (2016-01-27 15:15:21 UTC) #6
sergei
On 2016/01/27 15:15:21, Eric wrote: > On 2016/01/27 09:23:15, sergei wrote: > > I have ...
Jan. 29, 2016, 12:59 p.m. (2016-01-29 12:59:20 UTC) #7
Eric
On 2016/01/29 12:59:20, sergei wrote: > Version number of v8 is defined in the issue. ...
Feb. 9, 2016, 3:06 p.m. (2016-02-09 15:06:27 UTC) #8
sergei
Feb. 18, 2016, 10:52 a.m. (2016-02-18 10:52:28 UTC) #9
On 2016/02/09 15:06:27, Eric wrote:
> On 2016/01/29 12:59:20, sergei wrote:
> > Version number of v8 is defined in the issue. 
> 
> I see "Issue 5145227803230208" and I don't see a v8 version number anywhere on
> this page.
> 
> If you're talking about a ticket in Trac, that's not what I'm asking for. We
> need a version number of v8 in the commit message for the present change set.
> 
> > In addition, it's not
> > in https://codereview.adblockplus.org/6193234183192576/ because it is a
> > self-contained change and it reliefs that codereview (6193234183192576).
> 
> It's fine that it's self contained. It still needs a version number of v8 of
its
> own so that it can be audited against an externally-changing v8 code base.
Added `(from v8 4.3.15)` into the commit message.

Powered by Google App Engine
This is Rietveld