Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5188168852701184: Issue 1769 - CPluginUserSettingsInvoke.InvalidDispatchIdShouldOverflow crashes (Closed)

Created:
Jan. 9, 2015, 1:34 p.m. by sergei
Modified:
Jan. 19, 2015, 4:16 p.m.
Reviewers:
Oleksandr
CC:
Eric
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/plugin/UserSettingsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
sergei
Jan. 9, 2015, 1:36 p.m. (2015-01-09 13:36:14 UTC) #1
Eric
This same change is already present in http://codereview.adblockplus.org/5979857238360064/
Jan. 9, 2015, 2:23 p.m. (2015-01-09 14:23:54 UTC) #2
Oleksandr
Jan. 15, 2015, 11:17 a.m. (2015-01-15 11:17:07 UTC) #3
LGTM, we shouldn't bundle this with refactoring, IMHO.

Powered by Google App Engine
This is Rietveld