Issue 5189151393579008: Issue 2142 - Synchronize access to s_threadInstances in CPluginClass::OnTabChanged

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5189151393579008: Issue 2142 - Synchronize access to s_threadInstances in CPluginClass::OnTabChanged

Created:
March 16, 2015, 10:57 a.m. by Oleksandr

Modified:
June 15, 2015, 7:29 a.m.

Reviewers:
sergei, Eric

Visibility:
Public.

Description

Synchronize access to s_threadInstances in CPluginClass::OnTabChanged

Patch Set 1 #

Total comments: 1

Created: March 16, 2015, 10:57 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/plugin/PluginClass.cpp	View		1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Eric

March 16, 2015, 12:19 p.m. (2015-03-16 12:19:44 UTC) #2

I'm adding comments to #2142, since the way the issue description is written
leaves much to be desired.

The short version is that 's_threadinstances' has much larger problems that just
this place in the code. It's not even clear to me that the problem statement is
correct.

http://codereview.adblockplus.org/5189151393579008/diff/5629499534213120/src/...
File src/plugin/PluginClass.cpp (right):

http://codereview.adblockplus.org/5189151393579008/diff/5629499534213120/src/...
src/plugin/PluginClass.cpp:612: s_criticalSectionLocal.Lock();
The atomic action required here needs to surround both the call to 'find' as
well as adding a new element to the map.

Putting initialization inside the synchronized section isn't a good thing. Use
of the "test and set" pattern enables it to be outside.

Expand All Messages | Collapse All Messages