Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5195376613130240: Issue #1762 - Remove smart handle for HMODULE (Closed)

Created:
Jan. 7, 2015, 7:38 p.m. by Eric
Modified:
Jan. 13, 2015, 3:06 p.m.
Reviewers:
Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue #1762 - Remove smart handle for HMODULE The return value from LoadLibrary is an HMODULE, which is not a proper handle. In particular, it shouldn't be closed. Thus the use of a smart handle class to ensure closing the handle upon destruction is not only unnecessary but incorrect.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -27 lines) Patch
M installer/src/installer-lib/handle.h View 1 chunk +0 lines, -1 line 0 comments Download
M installer/src/installer-lib/process.cpp View 1 chunk +15 lines, -26 lines 0 comments Download

Messages

Total messages: 2
Eric
Jan. 7, 2015, 7:41 p.m. (2015-01-07 19:41:35 UTC) #1
Oleksandr
Jan. 13, 2015, 10:08 a.m. (2015-01-13 10:08:46 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld