Issue 5242186790600704: Issue 1466 - Fix a typo in PluginDomTraverserBase.h

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5242186790600704: Issue 1466 - Fix a typo in PluginDomTraverserBase.h (Closed)

Created:
Feb. 25, 2015, 6:34 p.m. by Oleksandr

Modified:
Feb. 26, 2015, 3:50 p.m.

Reviewers:
sergei, Eric

CC:
Felix Dahlke

Visibility:
Public.

Description

This causes some hide filters to be unapplied

Patch Set 1 #

Total comments: 1

Created: Feb. 25, 2015, 6:34 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/plugin/PluginDomTraverserBase.h	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Eric

LGTM http://codereview.adblockplus.org/5242186790600704/diff/5629499534213120/src/plugin/PluginDomTraverserBase.h File src/plugin/PluginDomTraverserBase.h (left): http://codereview.adblockplus.org/5242186790600704/diff/5629499534213120/src/plugin/PluginDomTraverserBase.h#oldcode277 src/plugin/PluginDomTraverserBase.h:277: if (SUCCEEDED(pFrameEl->getAttribute(ATL::CComBSTR(L"scr"), 0, &vAttr)) && vAttr.vt == VT_BSTR ...

Feb. 25, 2015, 9:47 p.m. (2015-02-25 21:47:14 UTC) #1

LGTM

Expand All Messages | Collapse All Messages