Noissue - Removed unused filter-map variables

Noissue - Removed unused filter-map variables

Remove dead variables and their associated typedefs.

[Eric, 2015-02-11 17:41:10]

Dead code.

[sergei, 2015-02-11 20:54:01]

However, it does not fix #1654, it would be better to make it as "No issue".

[Oleksandr, 2015-02-12 01:34:10]

On 2015/02/11 20:54:01, sergei wrote:
> However, it does not fix #1654, it would be better to make it as "No issue".

@Sergei, do you mean that you can still experience the crash with this patch set
applied? This seems to fix the possible crash, as it seems from the callstack.

[sergei, 2015-02-12 13:29:51]

On 2015/02/12 01:34:10, Oleksandr wrote:
> On 2015/02/11 20:54:01, sergei wrote:
> > However, it does not fix #1654, it would be better to make it as "No issue".
> 
> @Sergei, do you mean that you can still experience the crash with this patch
set
> applied? This seems to fix the possible crash, as it seems from the callstack.

Sure, it still crashes.

Let's consider the case, while FilterLoader thread was reaching the body of
CPluginFilter::ClearFilters the instance of CPluginTabBase had been destroyed.
In that case we are not allowed to access neither only member of CPluginFilter
nor even any member of CPluginTabBase (and in particular m_filter). Exactly as
it mentioned in the issue description. Playing with the debugger I can very well
reproduce it.

[Eric, 2015-02-12 18:33:37]

Changed commit text.

[Eric, 2015-02-12 18:35:00]

On 2015/02/12 13:29:51, sergei wrote:
> Exactly as
> it mentioned in the issue description. Playing with the debugger I can very
well
> reproduce it.

That issue description is a little to brief for its own good. How many tabs? How
quickly? Is this a crash that ever generates a system dialog?

[sergei, 2015-02-12 18:46:18]

On 2015/02/12 18:35:00, Eric wrote:
> On 2015/02/12 13:29:51, sergei wrote:
> > Exactly as
> > it mentioned in the issue description. Playing with the debugger I can very
> well
> > reproduce it.
> 
> That issue description is a little to brief for its own good. How many tabs?
How
> quickly? Is this a crash that ever generates a system dialog?

It can happen with one tab and it generates system dialog but it's very
difficult to reproduce it especially with one tab.

[Eric, 2015-02-12 18:59:03]

On 2015/02/12 18:46:18, sergei wrote:
> It can happen with one tab and it generates system dialog but it's very
> difficult to reproduce it especially with one tab.

Thank you, but I should be more explicit. Please modify the ticket in Trac to
add all this information.

[Eric, 2015-02-13 14:26:55]

OK. This review and the other one that came from looking into #1654 should be
ready to go.

[sergei, 2015-02-13 14:42:19]

LGTM

[Oleksandr, 2015-02-17 12:22:34]

LGTM