Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5394579117309952: Installer localization and new build system (Closed)

Created:
Dec. 10, 2013, 4:11 a.m. by Eric
Modified:
July 18, 2014, 4:39 p.m.
Visibility:
Public.

Description

Installer localization and new build system This is from my current working branch of the new installer. It follows after http://codereview.adblockplus.org/22887001/. In the wake of writing a gyp project for the MSI, including the CA, I've also been rearranging the directory structure; not all those changes have been made yet. Note: This is not a complete installer yet, which is why it's still on a branch. Notably, the setup.exe wrapper likely won't build. Localization files (.wxl) are available for all 38 languages that we have .ini's for in the plugin itself. A few of these languages are not included because WiX UI lacks localizations for them; we'll have to supply them. The build scripts will need to change to accommodate further arguments; that's scoped for the next round. Nevertheless, all the .wxl are present so that the linguists can have them. This version does not localize the Summary Information. There are code pages issues still. The fields that will end up in the SIS, however, are present in the .wxl files, again so that we can get translations for them as part of the same process. The default language for the install is LCID 7, German without a sublanguage specific (generic). Under testing, the embedded transform for LCID 9, generic English, has worked reliably for me. The installer databases are encoded in UTF-8 consistently, without using language-specific code page specifiers. It displays fine for me, but we will need testing for this. Related, The .wxl strings LANG and CODEPAGE are not being currently used and should be considered documentation at this point. They'll be removed later, after we've done functional testing and are sure we won't need to refer back to those values. OpenMCDF on SourceForge can be used to see the presence of the embedded transforms, but little else of use.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2027 lines, -18 lines) Patch
M installer/adblockplusie.wxs View 13 chunks +68 lines, -16 lines 0 comments Download
A installer/emb.vbs View 1 chunk +40 lines, -0 lines 0 comments Download
M installer/installer.gyp View 2 chunks +655 lines, -1 line 0 comments Download
A installer/msibuild.cmd View 1 chunk +81 lines, -0 lines 0 comments Download
A installer/src/documentation/build_process.dox View 1 chunk +110 lines, -0 lines 0 comments Download
A installer/src/documentation/localization.dox View 1 chunk +219 lines, -0 lines 0 comments Download
M installer/src/documentation/mainpage.dox View 1 chunk +38 lines, -1 line 0 comments Download
A installer/src/documentation/source_code.dox View 1 chunk +108 lines, -0 lines 0 comments Download
A installer/src/msi/locale/ar.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/bg-BG.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/ca-ES.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/cs-CZ.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/da-DK.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/de.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/el-GR.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/en.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/es-ES.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/et-EE.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/fi-FI.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/fil-PH.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/fr.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/he-IL.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/hi-IN.wxl View 1 chunk +21 lines, -0 lines 0 comments Download
A installer/src/msi/locale/hr-HR.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/hu-HU.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/it.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/ja-JP.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/kn-IN.wxl View 1 chunk +21 lines, -0 lines 0 comments Download
A installer/src/msi/locale/mr-IN.wxl View 1 chunk +21 lines, -0 lines 0 comments Download
A installer/src/msi/locale/ms.wxl View 1 chunk +21 lines, -0 lines 0 comments Download
A installer/src/msi/locale/nb-NO.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/nl.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/nn-NO.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/pl-PL.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/pt-BR.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/pt-PT.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/ro-RO.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/ru-RU.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/sk-SK.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/sv-SE.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/th-TH.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/tr-TR.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/uk-UA.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/ur-PK.wxl View 1 chunk +18 lines, -0 lines 0 comments Download
A installer/src/msi/locale/zh-CN.wxl View 1 chunk +23 lines, -0 lines 0 comments Download
A installer/src/msi/locale/zh-TW.wxl View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Eric
Dec. 10, 2013, 4:37 a.m. (2013-12-10 04:37:02 UTC) #1
Oleksandr
On 2013/12/10 04:37:02, Eric wrote: This can be closed, since we have Whole Installer review ...
July 15, 2014, 2:18 p.m. (2014-07-15 14:18:24 UTC) #2
Eric
July 18, 2014, 4:38 p.m. (2014-07-18 16:38:10 UTC) #3
See review for "Whole installer"
http://codereview.adblockplus.org/6202981292703744/

Powered by Google App Engine
This is Rietveld