Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5516878722105344: Issue #276 - replace TCHAR etc. with wide-character versions (Closed)

Created:
July 26, 2014, 2:20 p.m. by Eric
Modified:
Aug. 5, 2014, 3:24 p.m.
Visibility:
Public.

Description

Issue #276 - replace TCHAR etc. with wide-character versions As part of the replacement of the ATL string classes with standard versions, we replace TCHAR and all the other symbols with configuration-dependent character sizes with their wide-character versions. TCHAR --> wchar_t _T("...") --> L"..." _tcscmp --> wcscmp _tcslwr_s --> _wcslwr_s _tcsstr --> wcsstr

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -25 lines) Patch
M src/plugin/Config.h View 1 chunk +1 line, -1 line 0 comments Download
M src/plugin/Console.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/plugin/Plugin.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/plugin/PluginClass.cpp View 1 9 chunks +13 lines, -14 lines 0 comments Download
M src/plugin/PluginFilter.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/plugin/PluginSystem.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Eric
July 26, 2014, 2:22 p.m. (2014-07-26 14:22:53 UTC) #1
Eric
Note: This change set does not eliminate quite all the uses of the macro _T(). ...
July 26, 2014, 6:56 p.m. (2014-07-26 18:56:02 UTC) #2
sergei
I've checked only the changes. Looks good.
July 28, 2014, 9:27 a.m. (2014-07-28 09:27:02 UTC) #3
Oleksandr
Aug. 5, 2014, 11:29 a.m. (2014-08-05 11:29:54 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld