Issue 5634261554036736: Issue 1562 - Improve detecting of XmlHttmlRequest requests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5634261554036736: Issue 1562 - Improve detecting of XmlHttmlRequest requests (Closed)

Created:
Nov. 13, 2014, 9:11 a.m. by sergei

Modified:
Nov. 21, 2014, 11:13 a.m.

Reviewers:
Oleksandr

CC:
Eric, Felix Dahlke

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : add CORS #

Created: Nov. 13, 2014, 10:42 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -35 lines)			Patch
	M	src/plugin/PluginWbPassThrough.cpp	View	1	3 chunks	+52 lines, -35 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Oleksandr

On 2014/11/13 10:42:24, sergei wrote: > added CORS I think for the time being at ...

Nov. 20, 2014, 11:15 a.m. (2014-11-20 11:15:13 UTC) #3

sergei

On 2014/11/20 11:15:13, Oleksandr wrote: > On 2014/11/13 10:42:24, sergei wrote: > > added CORS ...

Nov. 21, 2014, 10:55 a.m. (2014-11-21 10:55:15 UTC) #4

Oleksandr

Nov. 21, 2014, 11:07 a.m. (2014-11-21 11:07:54 UTC) #5

In that case LGTM without CORS. We can commit that in a separate patch later.

On 2014/11/21 10:55:15, sergei wrote:
> On 2014/11/20 11:15:13, Oleksandr wrote:
> > On 2014/11/13 10:42:24, sergei wrote:
> > > added CORS
> > 
> > I think for the time being at least there is more harm in not classifying
some
> > XMLHttpRequests as XMLHttpRequest, then in classifying some WebGL or
WebFonts
> > requests accidentally as XMLHttpRequest. I'd vote for pushing this.
> 
> I've moved the discussion to issue tracker.

Expand All Messages | Collapse All Messages