Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5652794446970880: Rely on libadblockplus for domain extraction (Closed)

Created:
April 22, 2014, 7:40 a.m. by Oleksandr
Modified:
June 26, 2014, 1:04 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Rely on libadblockplus for domain extraction

Patch Set 1 #

Patch Set 2 : Use libadblockplus for domain extraction in APP as well #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -29 lines) Patch
M src/engine/Main.cpp View 1 chunk +15 lines, -0 lines 0 comments Download
M src/plugin/AdblockPlusClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/plugin/AdblockPlusClient.cpp View 1 chunk +13 lines, -0 lines 1 comment Download
M src/plugin/PluginClass.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/plugin/PluginTabBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/plugin/PluginUtil.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/plugin/PluginUtil.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M src/plugin/PluginWbPassThrough.cpp View 1 1 chunk +1 line, -13 lines 0 comments Download
M src/shared/Communication.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3
Oleksandr
April 22, 2014, 7:41 a.m. (2014-04-22 07:41:30 UTC) #1
Oleksandr
Felix, it would be great if you reviewed this
May 23, 2014, 9:01 a.m. (2014-05-23 09:01:28 UTC) #2
Felix Dahlke
June 24, 2014, 3:13 p.m. (2014-06-24 15:13:47 UTC) #3
LGTM!

http://codereview.adblockplus.org/5652794446970880/diff/5741031244955648/src/...
File src/plugin/AdblockPlusClient.cpp (right):

http://codereview.adblockplus.org/5652794446970880/diff/5741031244955648/src/...
src/plugin/AdblockPlusClient.cpp:546: std::wstring
CAdblockPlusClient::GetHostFromUrl(const std::wstring& url)
One empty line above the function header for consistency's sake?

Powered by Google App Engine
This is Rietveld