Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(380)

Issue 5710085762318336: 1757 - Integrate ensure_dependencies.py with the adblockpluschrome repository (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 11 months ago by paco
Modified:
4 years, 10 months ago
CC:
mathias, aalvz, kzar
Visibility:
Public.

Description

In #170 we introduced our custom dependency mechanism, this is the patch to use that mechanism in this repo

Patch Set 1 #

Total comments: 6

Patch Set 2 : '1757 - Integrate ensure_dependencies.py with the adblockpluschrome repository' #

Total comments: 6

Patch Set 3 : '1757 - Integrate ensure_dependencies.py with the adblockpluschrome repository' #

Total comments: 3

Patch Set 4 : '1757 - Integrate ensure_dependencies.py with the adblockpluschrome repository' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -8 lines) Patch
R .hgsub View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
R .hgsubstate View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M build.py View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
A dependencies View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
A ensure_dependencies.py View 1 2 3 1 chunk +299 lines, -0 lines 0 comments Download

Messages

Total messages: 14
paco
4 years, 11 months ago (2015-01-13 17:14:10 UTC) #1
Sebastian Noack
http://codereview.adblockplus.org/5710085762318336/diff/5629499534213120/build.py File build.py (right): http://codereview.adblockplus.org/5710085762318336/diff/5629499534213120/build.py#newcode8 build.py:8: if os.path.isfile(DEPENDENCY_SCRIPT): Why do you check whether the script ...
4 years, 11 months ago (2015-01-13 17:21:52 UTC) #2
paco
4 years, 11 months ago (2015-01-14 11:40:21 UTC) #3
paco
http://codereview.adblockplus.org/5710085762318336/diff/5629499534213120/build.py File build.py (right): http://codereview.adblockplus.org/5710085762318336/diff/5629499534213120/build.py#newcode8 build.py:8: if os.path.isfile(DEPENDENCY_SCRIPT): On 2015/01/13 17:21:53, Sebastian Noack wrote: > ...
4 years, 11 months ago (2015-01-14 11:40:49 UTC) #4
Sebastian Noack
http://codereview.adblockplus.org/5710085762318336/diff/5629499534213120/build.py File build.py (right): http://codereview.adblockplus.org/5710085762318336/diff/5629499534213120/build.py#newcode8 build.py:8: if os.path.isfile(DEPENDENCY_SCRIPT): On 2015/01/14 11:40:49, paco wrote: > On ...
4 years, 11 months ago (2015-01-14 11:58:45 UTC) #5
Wladimir Palant
http://codereview.adblockplus.org/5710085762318336/diff/5629499534213120/build.py File build.py (right): http://codereview.adblockplus.org/5710085762318336/diff/5629499534213120/build.py#newcode8 build.py:8: if os.path.isfile(DEPENDENCY_SCRIPT): On 2015/01/14 11:58:46, Sebastian Noack wrote: > ...
4 years, 11 months ago (2015-01-14 13:11:16 UTC) #6
paco
http://codereview.adblockplus.org/5710085762318336/diff/5629499534213120/build.py File build.py (right): http://codereview.adblockplus.org/5710085762318336/diff/5629499534213120/build.py#newcode8 build.py:8: if os.path.isfile(DEPENDENCY_SCRIPT): On 2015/01/14 13:11:17, Wladimir Palant wrote: > ...
4 years, 11 months ago (2015-01-14 16:00:36 UTC) #7
paco
4 years, 11 months ago (2015-01-14 16:08:44 UTC) #8
Sebastian Noack
http://codereview.adblockplus.org/5710085762318336/diff/5634387206995968/build.py File build.py (right): http://codereview.adblockplus.org/5710085762318336/diff/5634387206995968/build.py#newcode13 build.py:13: Maybe exit with a non-0 status code?
4 years, 11 months ago (2015-01-14 16:34:13 UTC) #9
Sebastian Noack
LGTM http://codereview.adblockplus.org/5710085762318336/diff/5634387206995968/build.py File build.py (right): http://codereview.adblockplus.org/5710085762318336/diff/5634387206995968/build.py#newcode13 build.py:13: On 2015/01/14 16:34:13, Sebastian Noack wrote: > Maybe ...
4 years, 11 months ago (2015-01-14 17:28:36 UTC) #10
Wladimir Palant
LGTM http://codereview.adblockplus.org/5710085762318336/diff/5634387206995968/build.py File build.py (right): http://codereview.adblockplus.org/5710085762318336/diff/5634387206995968/build.py#newcode13 build.py:13: On 2015/01/14 16:34:13, Sebastian Noack wrote: > Maybe ...
4 years, 11 months ago (2015-01-14 17:42:45 UTC) #11
Sebastian Noack
Two more things: 1. Please make ensure_dependencies.py executable (according to Wladimir it is executable in ...
4 years, 10 months ago (2015-01-15 11:28:57 UTC) #12
paco
4 years, 10 months ago (2015-01-15 13:41:00 UTC) #13
Sebastian Noack
4 years, 10 months ago (2015-01-15 13:59:13 UTC) #14
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5