Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5743529531801600: Playing with Default behavior for catch-all blocks

Created:
March 31, 2015, 1:45 p.m. by sergei
Modified:
June 15, 2015, 7:28 a.m.
Reviewers:
Eric, Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Patch Set 1 : Original patch set 9 #

Patch Set 2 : proposed changes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1023 lines, -616 lines) Patch
M adblockplus.gyp View 3 chunks +3 lines, -1 line 0 comments Download
A src/plugin/Exception.h View 1 1 chunk +88 lines, -0 lines 0 comments Download
M src/plugin/PluginClass.cpp View 6 chunks +6 lines, -0 lines 0 comments Download
M src/plugin/PluginDebug.h View 1 chunk +107 lines, -47 lines 0 comments Download
M src/plugin/PluginDebug.cpp View 1 chunk +336 lines, -256 lines 0 comments Download
D src/plugin/PluginErrorCodes.h View 1 chunk +0 lines, -215 lines 0 comments Download
M src/plugin/PluginStdAfx.h View 1 chunk +96 lines, -97 lines 0 comments Download
A test/plugin/ExceptionTest.cpp View 1 1 chunk +387 lines, -0 lines 1 comment Download

Messages

Total messages: 1
sergei
April 1, 2015, 7:16 a.m. (2015-04-01 07:16:02 UTC) #1
http://codereview.adblockplus.org/5743529531801600/diff/5136918324969472/test...
File test/plugin/ExceptionTest.cpp (right):

http://codereview.adblockplus.org/5743529531801600/diff/5136918324969472/test...
test/plugin/ExceptionTest.cpp:243: static void Exception(const
std::logic_error&, UserData) { FAIL() << "Unexpected std::logic_error"; }
JIC, actually, these three methods as well as the same methods of
SimpleHandlersReturnBase can be also removed, however it may be good to keep the
for the sake of demonstration of the overriding of them.

Powered by Google App Engine
This is Rietveld