Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5748224216268800: No issue - some cleanup in PluginWbPassThrough (Closed)

Created:
Nov. 13, 2014, 10:20 a.m. by sergei
Modified:
Nov. 19, 2014, 2:10 p.m.
Reviewers:
Oleksandr
CC:
Felix Dahlke, Eric
Visibility:
Public.

Description

- make global g_blockedByABPPage to be const - add nullptr validation for some pointers before dereferencing - remove pointless overrides of LockRequest and UnlockRequest

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove verifying of szHeaders #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -20 lines) Patch
M src/plugin/PluginWbPassThrough.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/plugin/PluginWbPassThrough.cpp View 1 5 chunks +7 lines, -17 lines 0 comments Download

Messages

Total messages: 4
sergei
Nov. 13, 2014, 10:22 a.m. (2014-11-13 10:22:01 UTC) #1
Oleksandr
http://codereview.adblockplus.org/5748224216268800/diff/5629499534213120/src/plugin/PluginWbPassThrough.cpp File src/plugin/PluginWbPassThrough.cpp (right): http://codereview.adblockplus.org/5748224216268800/diff/5629499534213120/src/plugin/PluginWbPassThrough.cpp#newcode277 src/plugin/PluginWbPassThrough.cpp:277: if (!szURL || !szHeaders) Why can't szHeaders be nullptr? ...
Nov. 19, 2014, 2:34 a.m. (2014-11-19 02:34:59 UTC) #2
sergei
http://codereview.adblockplus.org/5748224216268800/diff/5629499534213120/src/plugin/PluginWbPassThrough.cpp File src/plugin/PluginWbPassThrough.cpp (right): http://codereview.adblockplus.org/5748224216268800/diff/5629499534213120/src/plugin/PluginWbPassThrough.cpp#newcode277 src/plugin/PluginWbPassThrough.cpp:277: if (!szURL || !szHeaders) On 2014/11/19 02:34:59, Oleksandr wrote: ...
Nov. 19, 2014, 11:05 a.m. (2014-11-19 11:05:02 UTC) #3
Oleksandr
Nov. 19, 2014, 1:39 p.m. (2014-11-19 13:39:12 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld