Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(286)

Issue 5748296123416576: Issue 1166 - Import strings from ABP for Firefox (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 5 months ago by Felix Dahlke
Modified:
5 years, 5 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 1166 - Import strings from ABP for Firefox

Patch Set 1 : #

Total comments: 21

Patch Set 2 : Comments addressed #

Patch Set 3 : Use localeTools.langMappingGecko, don't hard code IE locales #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -54 lines) Patch
M .hgsub View 1 chunk +1 line, -0 lines 0 comments Download
M .hgsubstate View 1 chunk +1 line, -0 lines 0 comments Download
A import_locales.py View 1 2 1 chunk +77 lines, -0 lines 0 comments Download
M locales/ar.ini View 1 2 chunks +6 lines, -3 lines 0 comments Download
M locales/bg.ini View 2 chunks +3 lines, -0 lines 0 comments Download
M locales/ca.ini View 2 chunks +3 lines, -0 lines 0 comments Download
M locales/cs.ini View 2 chunks +3 lines, -0 lines 0 comments Download
M locales/da.ini View 2 chunks +3 lines, -0 lines 0 comments Download
M locales/de.ini View 2 chunks +3 lines, -0 lines 0 comments Download
M locales/el.ini View 1 2 chunks +6 lines, -3 lines 0 comments Download
M locales/en.ini View 1 chunk +1 line, -1 line 0 comments Download
M locales/es-ES.ini View 2 chunks +3 lines, -0 lines 0 comments Download
M locales/et.ini View 2 chunks +2 lines, -0 lines 0 comments Download
M locales/fi.ini View 1 chunk +3 lines, -1 line 0 comments Download
M locales/fr.ini View 2 chunks +3 lines, -0 lines 0 comments Download
M locales/he.ini View 1 2 chunks +3 lines, -0 lines 0 comments Download
M locales/hi.ini View 1 chunk +25 lines, -24 lines 0 comments Download
M locales/hr.ini View 1 chunk +3 lines, -1 line 0 comments Download
M locales/hu.ini View 2 chunks +3 lines, -0 lines 0 comments Download
M locales/it.ini View 2 chunks +3 lines, -0 lines 0 comments Download
M locales/ja.ini View 1 1 chunk +18 lines, -15 lines 0 comments Download
M locales/kn.ini View 1 1 chunk +2 lines, -2 lines 0 comments Download
M locales/mr.ini View 1 chunk +2 lines, -0 lines 0 comments Download
M locales/ms.ini View 2 chunks +3 lines, -0 lines 0 comments Download
M locales/nb.ini View 1 2 chunks +3 lines, -0 lines 0 comments Download
M locales/nl.ini View 2 chunks +3 lines, -0 lines 0 comments Download
M locales/pl.ini View 1 3 chunks +4 lines, -1 line 0 comments Download
M locales/pt-BR.ini View 2 chunks +3 lines, -0 lines 0 comments Download
M locales/pt-PT.ini View 2 chunks +3 lines, -0 lines 0 comments Download
M locales/ro.ini View 2 chunks +3 lines, -0 lines 0 comments Download
M locales/ru.ini View 1 2 chunks +3 lines, -0 lines 0 comments Download
M locales/sk.ini View 2 chunks +3 lines, -0 lines 0 comments Download
M locales/sv-SE.ini View 2 chunks +3 lines, -0 lines 0 comments Download
M locales/th.ini View 3 chunks +3 lines, -1 line 0 comments Download
M locales/tr.ini View 2 chunks +3 lines, -0 lines 0 comments Download
M locales/uk.ini View 2 chunks +4 lines, -2 lines 0 comments Download
M locales/zh-CN.ini View 1 2 chunks +3 lines, -0 lines 0 comments Download
M locales/zh-TW.ini View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8
Felix Dahlke
http://codereview.adblockplus.org/5748296123416576/diff/5668600916475904/import_locales.py File import_locales.py (right): http://codereview.adblockplus.org/5748296123416576/diff/5668600916475904/import_locales.py#newcode51 import_locales.py:51: "en": "en-US", There are two other locales we probably ...
5 years, 5 months ago (2014-08-05 16:14:16 UTC) #1
Felix Dahlke
http://codereview.adblockplus.org/5748296123416576/diff/5685265389584384/import_locales.py File import_locales.py (right): http://codereview.adblockplus.org/5748296123416576/diff/5685265389584384/import_locales.py#newcode51 import_locales.py:51: "en": "en-US", There are two other locales we probably ...
5 years, 5 months ago (2014-08-05 16:38:59 UTC) #2
Wladimir Palant
What happened to "import at build time"? The current solution is what we used for ...
5 years, 5 months ago (2014-08-06 06:09:04 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/5748296123416576/diff/5685265389584384/import_locales.py File import_locales.py (right): http://codereview.adblockplus.org/5748296123416576/diff/5685265389584384/import_locales.py#newcode104 import_locales.py:104: value = value.replace("&", "") This won't do the job ...
5 years, 5 months ago (2014-08-06 06:11:04 UTC) #4
Felix Dahlke
New patch set, the remaining issue now is to list all the possible locales. http://codereview.adblockplus.org/5748296123416576/diff/5685265389584384/import_locales.py ...
5 years, 5 months ago (2014-08-06 10:32:07 UTC) #5
Wladimir Palant
LGTM http://codereview.adblockplus.org/5748296123416576/diff/5685265389584384/import_locales.py File import_locales.py (right): http://codereview.adblockplus.org/5748296123416576/diff/5685265389584384/import_locales.py#newcode53 import_locales.py:53: "nb": "nb-NO" On 2014/08/06 10:32:08, Felix H. Dahlke ...
5 years, 5 months ago (2014-08-06 10:50:58 UTC) #6
Felix Dahlke
Uploaded a new patch set that doesn't hard code the IE locales, and that uses ...
5 years, 5 months ago (2014-08-06 12:14:05 UTC) #7
Wladimir Palant
5 years, 5 months ago (2014-08-06 15:10:55 UTC) #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5